[SPARK-31181][SQL][TESTS] Remove the default value assumption on CREATE TABLE test cases #27946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
dongjoon-hyun
changed the title
dongjoon-hyun
commented
Mar 18, 2020
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLParserSuite.scala
Outdated
Show resolved
Hide resolved
|
Test build #119980 has finished for PR 27946 at commit
|
Member
Author
|
Hi, @cloud-fan . Could you review this PR? |
cloud-fan
reviewed
Mar 19, 2020
|
|
||
| -- [SPARK-19842] Informational Referential Integrity Constraints Support in Spark | ||
| CREATE TABLE view_base_table (key int /* PRIMARY KEY */, data varchar(20)); | ||
| CREATE TABLE view_base_table (key int /* PRIMARY KEY */, data varchar(20)) USING PARQUET; |
Contributor
There was a problem hiding this comment.
Shall we keep the pgsql test as what it is in pgsql?
Member
Author
There was a problem hiding this comment.
Hi, @cloud-fan . We are using CREATE TABLE USING even in pgsql test. It's okay to change this.
cloud-fan
reviewed
Mar 19, 2020
sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Mar 19, 2020
sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala
Outdated
Show resolved
Hide resolved
|
Test build #120066 has finished for PR 27946 at commit
|
Contributor
|
thanks, merging to master/3.0! |
Member
Author
|
Thank you, @cloud-fan ! Also, I closed #27894. |
dongjoon-hyun
added a commit
that referenced
this pull request
Mar 20, 2020
…TE TABLE test cases A few `CREATE TABLE` test cases have some assumption on the default value of `LEGACY_CREATE_HIVE_TABLE_BY_DEFAULT_ENABLED`. This PR (SPARK-31181) makes the test cases more explicit from test-case side. The configuration change was tested via #27894 during discussing SPARK-31136. This PR has only the test case part from that PR. This makes our test case more robust in terms of the default value of `LEGACY_CREATE_HIVE_TABLE_BY_DEFAULT_ENABLED`. Even in the case where we switch the conf value, that will be one-liner with no test case changes. No. Pass the Jenkins with the existing tests. Closes #27946 from dongjoon-hyun/SPARK-EXPLICIT-TEST. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit f1cc867) Signed-off-by: Dongjoon Hyun <[email protected]>
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
…TE TABLE test cases ### What changes were proposed in this pull request? A few `CREATE TABLE` test cases have some assumption on the default value of `LEGACY_CREATE_HIVE_TABLE_BY_DEFAULT_ENABLED`. This PR (SPARK-31181) makes the test cases more explicit from test-case side. The configuration change was tested via apache#27894 during discussing SPARK-31136. This PR has only the test case part from that PR. ### Why are the changes needed? This makes our test case more robust in terms of the default value of `LEGACY_CREATE_HIVE_TABLE_BY_DEFAULT_ENABLED`. Even in the case where we switch the conf value, that will be one-liner with no test case changes. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Pass the Jenkins with the existing tests. Closes apache#27946 from dongjoon-hyun/SPARK-EXPLICIT-TEST. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
A few
CREATE TABLEtest cases have some assumption on the default value ofLEGACY_CREATE_HIVE_TABLE_BY_DEFAULT_ENABLED. This PR (SPARK-31181) makes the test cases more explicit from test-case side.The configuration change was tested via #27894 during discussing SPARK-31136. This PR has only the test case part from that PR.
Why are the changes needed?
This makes our test case more robust in terms of the default value of
LEGACY_CREATE_HIVE_TABLE_BY_DEFAULT_ENABLED. Even in the case where we switch the conf value, that will be one-liner with no test case changes.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the Jenkins with the existing tests.