Skip to content

Conversation

@brkyvz
Copy link
Contributor

@brkyvz brkyvz commented Mar 6, 2020

What changes were proposed in this pull request?

This PR adds functionality to HiveExternalCatalog to be able to change the provider of a table.

Why are the changes needed?

This is useful for catalogs in Spark 3.0 to be able to use alterTable to change the provider of a table as part of an atomic REPLACE TABLE function.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Unit tests


test("SPARK-31061: alterTable should be able to change table provider from hive") {
val catalog = newBasicCatalog()
val parquetTable = CatalogTable(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: hiveTable

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-31061][SQL][3.0] Provide ability to alter the provider of a table [SPARK-31061][SQL] Provide ability to alter the provider of a table Mar 6, 2020
@dongjoon-hyun
Copy link
Member

Hi, @brkyvz . [3.0] is used when you make a PR against branch-3.0 directly.

@SparkQA
Copy link

SparkQA commented Mar 6, 2020

Test build #119438 has finished for PR 27822 at commit 7a5f2c2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan cloud-fan closed this in 2e3adad Mar 6, 2020
@cloud-fan
Copy link
Contributor

thanks, merging to master/3.0! (I've fixed the typo in the test while merging)

cloud-fan pushed a commit that referenced this pull request Mar 6, 2020
This PR adds functionality to HiveExternalCatalog to be able to change the provider of a table.

This is useful for catalogs in Spark 3.0 to be able to use alterTable to change the provider of a table as part of an atomic REPLACE TABLE function.

No

Unit tests

Closes #27822 from brkyvz/externalCat.

Authored-by: Burak Yavuz <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
(cherry picked from commit 2e3adad)
Signed-off-by: Wenchen Fan <[email protected]>
sjincho pushed a commit to sjincho/spark that referenced this pull request Apr 15, 2020
This PR adds functionality to HiveExternalCatalog to be able to change the provider of a table.

This is useful for catalogs in Spark 3.0 to be able to use alterTable to change the provider of a table as part of an atomic REPLACE TABLE function.

No

Unit tests

Closes apache#27822 from brkyvz/externalCat.

Authored-by: Burak Yavuz <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants