Skip to content

[MINOR][DOC] Fix 2 style issues in running-on-kubernetes doc #27582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[MINOR][DOC] Fix 2 style issues in running-on-kubernetes doc #27582

wants to merge 1 commit into from

Conversation

@yaooqinn
Copy link
Member

@yaooqinn yaooqinn commented Feb 14, 2020 •
edited
Loading

What changes were proposed in this pull request?

fix style issue in the k8s document, please go to http://spark.apache.org/docs/3.0.0-preview2/running-on-kubernetes.html and search the keywordspark.kubernetes.file.upload.path to jump to the error context

Why are the changes needed?

doc correctness

Does this PR introduce any user-facing change?

Nah

How was this patch tested?

Nah

@SparkQA
Copy link

SparkQA commented Feb 14, 2020

Test build #118431 has finished for PR 27582 at commit 2414738.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Feb 14, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/23188/

@SparkQA
Copy link

SparkQA commented Feb 14, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/23188/

@yaooqinn
Copy link
Member Author

yaooqinn commented Feb 14, 2020

retest this please

attilapiros
attilapiros approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@attilapiros attilapiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to open a PR with the same html escaping :)

LGTM

@SparkQA
Copy link

SparkQA commented Feb 14, 2020

Test build #118436 has finished for PR 27582 at commit 2414738.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Feb 14, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/23193/

@SparkQA
Copy link

SparkQA commented Feb 14, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/23193/

@yaooqinn
Copy link
Member Author

yaooqinn commented Feb 15, 2020

retest this please

@SparkQA
Copy link

SparkQA commented Feb 15, 2020

Test build #118473 has finished for PR 27582 at commit 2414738.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Feb 15, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/23230/

@SparkQA
Copy link

SparkQA commented Feb 15, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/23230/

HyukjinKwon pushed a commit that referenced this pull request Feb 17, 2020
@yaooqinn @HyukjinKwon
[MINOR][DOC] Fix 2 style issues in running-on-kubernetes doc
44e314e 
### What changes were proposed in this pull request?

fix style issue in the k8s document, please go to http://spark.apache.org/docs/3.0.0-preview2/running-on-kubernetes.html and search the keyword`spark.kubernetes.file.upload.path` to jump to the error context

### Why are the changes needed?

doc correctness

### Does this PR introduce any user-facing change?

Nah
### How was this patch tested?

Nah

Closes #27582 from yaooqinn/k8s-doc.

Authored-by: Kent Yao <[email protected]>
Signed-off-by: HyukjinKwon <[email protected]>
(cherry picked from commit 0353cbf)
Signed-off-by: HyukjinKwon <[email protected]>
@HyukjinKwon
Copy link
Member

HyukjinKwon commented Feb 17, 2020

Merged to master and branch-3.0.

sjincho pushed a commit to sjincho/spark that referenced this pull request Apr 15, 2020
@yaooqinn
[MINOR][DOC] Fix 2 style issues in running-on-kubernetes doc
1388f2f 
### What changes were proposed in this pull request?

fix style issue in the k8s document, please go to http://spark.apache.org/docs/3.0.0-preview2/running-on-kubernetes.html and search the keyword`spark.kubernetes.file.upload.path` to jump to the error context

### Why are the changes needed?

doc correctness

### Does this PR introduce any user-facing change?

Nah
### How was this patch tested?

Nah

Closes apache#27582 from yaooqinn/k8s-doc.

Authored-by: Kent Yao <[email protected]>
Signed-off-by: HyukjinKwon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kiszk kiszk kiszk approved these changes

@attilapiros attilapiros attilapiros approved these changes

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yaooqinn @SparkQA @HyukjinKwon @kiszk @attilapiros