Skip to content

[R] DO NOT MERGE debugging R packages #27468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[R] DO NOT MERGE debugging R packages #27468

wants to merge 3 commits into from

Conversation

@shaneknapp
Copy link
Contributor

@shaneknapp shaneknapp commented Feb 5, 2020

What changes were proposed in this pull request?

no changes

Why are the changes needed?

no changes

Does this PR introduce any user-facing change?

no

How was this patch tested?

via build system

@SparkQA
Copy link

SparkQA commented Feb 5, 2020

Test build #117947 has started for PR 27468 at commit 2c02939.

@shaneknapp
Copy link
Contributor Author

shaneknapp commented Feb 5, 2020

totally weird:

Warning message:
roxygen2 requires Encoding: UTF-8

but the build env has that set:
LANG | en_US.UTF-8

maybe we need to s/en_us.// on the env var?

@SparkQA
Copy link

SparkQA commented Feb 5, 2020

Test build #117948 has finished for PR 27468 at commit a3ab80a.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shaneknapp
Copy link
Contributor Author

shaneknapp commented Feb 5, 2020

ok, htmltools resinstalled, which seems to have helped.

also, i don't think we ever had arrow installed... i'll put that on the list as well.

@shaneknapp
Copy link
Contributor Author

shaneknapp commented Feb 5, 2020

also, i don't think we ever had arrow installed... i'll put that on the list as well.

um, this is a much bigger project apparently, as i need to build arrow from source to create the C++ libs.

definitely out of scope of this PR.

@shaneknapp
Copy link
Contributor Author

shaneknapp commented Feb 5, 2020

ok, htmltools resinstalled, which seems to have helped.

also yaml, which seems to be the final package... i hope lol

@shaneknapp
Copy link
Contributor Author

shaneknapp commented Feb 5, 2020

test this please

@SparkQA
Copy link

SparkQA commented Feb 5, 2020

Test build #117951 has finished for PR 27468 at commit a3ab80a.

  • This patch fails R style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shaneknapp
Copy link
Contributor Author

shaneknapp commented Feb 5, 2020

test this please

@SparkQA
Copy link

SparkQA commented Feb 5, 2020

Test build #117952 has started for PR 27468 at commit ecbc087.

@shaneknapp
Copy link
Contributor Author

shaneknapp commented Feb 5, 2020

ok, htmltools resinstalled, which seems to have helped.

also yaml, which seems to be the final package... i hope lol

and plyr... re #27456 (comment)

@shaneknapp
Copy link
Contributor Author

shaneknapp commented Feb 5, 2020

test this please

@shaneknapp shaneknapp mentioned this pull request Feb 5, 2020
Closed
@SparkQA
Copy link

SparkQA commented Feb 5, 2020

Test build #117953 has finished for PR 27468 at commit ecbc087.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shaneknapp
Copy link
Contributor Author

shaneknapp commented Feb 5, 2020

ok, htmltools resinstalled, which seems to have helped.

also yaml, which seems to be the final package... i hope lol

add e1071 as well

@shaneknapp
Copy link
Contributor Author

shaneknapp commented Feb 5, 2020

test this please

@SparkQA
Copy link

SparkQA commented Feb 5, 2020

Test build #117954 has finished for PR 27468 at commit ecbc087.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shaneknapp
Copy link
Contributor Author

shaneknapp commented Feb 5, 2020

WOOT!

@HyukjinKwon do you want to open a PR to revert this change:
https://github.com/apache/spark/pull/27460/files#diff-9e63dce390dd4d80c6abe3413a8b1984R34

we might as well add the LANG setting for DESCRIPTION and make roxygen2 happy again:
ecbc087

@shaneknapp shaneknapp closed this Feb 5, 2020
@HyukjinKwon
Copy link
Member

HyukjinKwon commented Feb 6, 2020

Thanks, @shaneknapp. I will take a followup action accordingly.

@HyukjinKwon HyukjinKwon mentioned this pull request Feb 6, 2020
Closed
HyukjinKwon added a commit that referenced this pull request Feb 6, 2020
@HyukjinKwon
[SPARK-30737][SPARK-27262][R][BUILD] Reenable CRAN check with UTF-8 e…
b95ccb1 
…ncoding to DESCRIPTION

### What changes were proposed in this pull request?

This PR proposes to reenable CRAN check disabled at #27460. Given the tests #27468, seems we should also port #23823 together.

### Why are the changes needed?
To check CRAN back.

### Does this PR introduce any user-facing change?
No.

### How was this patch tested?
It was tested at #27468 and Jenkins should test it out.

Closes #27472 from HyukjinKwon/SPARK-30737.

Authored-by: HyukjinKwon <[email protected]>
Signed-off-by: HyukjinKwon <[email protected]>
HyukjinKwon added a commit that referenced this pull request Feb 6, 2020
@HyukjinKwon
[SPARK-30737][SPARK-27262][R][BUILD] Reenable CRAN check with UTF-8 e…
da1caae 
…ncoding to DESCRIPTION

### What changes were proposed in this pull request?

This PR proposes to reenable CRAN check disabled at #27460. Given the tests #27468, seems we should also port #23823 together.

### Why are the changes needed?
To check CRAN back.

### Does this PR introduce any user-facing change?
No.

### How was this patch tested?
It was tested at #27468 and Jenkins should test it out.

Closes #27472 from HyukjinKwon/SPARK-30737.

Authored-by: HyukjinKwon <[email protected]>
Signed-off-by: HyukjinKwon <[email protected]>
(cherry picked from commit b95ccb1)
Signed-off-by: HyukjinKwon <[email protected]>
HyukjinKwon added a commit that referenced this pull request Feb 6, 2020
@HyukjinKwon
[SPARK-30737][SPARK-27262][R][BUILD] Reenable CRAN check with UTF-8 e…
40062e3 
…ncoding to DESCRIPTION

### What changes were proposed in this pull request?

This PR proposes to reenable CRAN check disabled at #27460. Given the tests #27468, seems we should also port #23823 together.

### Why are the changes needed?
To check CRAN back.

### Does this PR introduce any user-facing change?
No.

### How was this patch tested?
It was tested at #27468 and Jenkins should test it out.

Closes #27472 from HyukjinKwon/SPARK-30737.

Authored-by: HyukjinKwon <[email protected]>
Signed-off-by: HyukjinKwon <[email protected]>
(cherry picked from commit b95ccb1)
Signed-off-by: HyukjinKwon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shaneknapp @SparkQA @HyukjinKwon