Skip to content

[SPARK-30192][SQL][FOLLOWUP] Rename SINGLETON to INSTANCE #27409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-30192][SQL][FOLLOWUP] Rename SINGLETON to INSTANCE #27409

wants to merge 1 commit into from

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jan 31, 2020 •
edited
Loading

What changes were proposed in this pull request?

This PR renames a variable SINGLETON to INSTANCE.

Why are the changes needed?

This is a minor change for consistency with the other parts.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the existing tests.

@dongjoon-hyun dongjoon-hyun mentioned this pull request Jan 31, 2020
Closed
@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Jan 31, 2020

Could you review this, @cloud-fan and @brkyvz ?

@SparkQA
Copy link

SparkQA commented Jan 31, 2020

Test build #117602 has finished for PR 27409 at commit 0d4d360.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Jan 31, 2020

Retest this please.

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Jan 31, 2020

Thank you for review and approval, @HyukjinKwon .

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Jan 31, 2020

Thank you for review and approval, @cloud-fan .

@SparkQA
Copy link

SparkQA commented Jan 31, 2020

Test build #117611 has finished for PR 27409 at commit 0d4d360.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Jan 31, 2020

Merged to master.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-30192 branch January 31, 2020 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cloud-fan cloud-fan cloud-fan approved these changes

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees

No one assigned

Labels

SQL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dongjoon-hyun @SparkQA @cloud-fan @HyukjinKwon