[SPARK-30676][CORE][TESTS] Eliminate warnings from deprecated constructors of java.lang.Integer and java.lang.Double #27399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #117555 has finished for PR 27399 at commit
|
srowen
reviewed
Jan 30, 2020
| * that only happens on the driver). | ||
| */ | ||
| private val stateLock = new Integer(0) | ||
| private val stateLock = new Serializable {} |
Member
There was a problem hiding this comment.
Yeah anything Serializable is fine. Integer.valueOf(0) isn't ideal because it's going to be a shared object. Anything would work - String("") for example. This seems OK to just slightly odd looking. It could also be a proper Lock, used as a lock, but whatever.
Member
There was a problem hiding this comment.
Seems OK to me as a minimal change that shouldn't matter for behavior.
srowen
approved these changes
Jan 31, 2020
Member
|
Merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
new Integer(0)by a serializable instance in RDD.scala.valueOf()instead of constructors ofjava.lang.Integerandjava.lang.Doublebecause constructors has been deprecated, see https://docs.oracle.com/javase/9/docs/api/java/lang/Integer.htmlWhy are the changes needed?
This fixes the following warnings:
Does this PR introduce any user-facing change?
No
How was this patch tested?