-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-30599][CORE][TESTS] Increase the maximum number of log events in LogAppender #27312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Jenkins test this please |
|
Test build #117196 has finished for PR 27312 at commit
|
|
jenkins, retest this, please |
|
Test build #117197 has finished for PR 27312 at commit
|
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
BTW, do we need this in |
|
Test build #117201 has finished for PR 27312 at commit
|
|
late LGTM; This common subclass has been implemented recently in 88fc8db. |
|
Got it. Thank you for confirmation, @maropu ! |
What changes were proposed in this pull request?
Increased the limit for log events that could be stored in
SparkFunSuite.LogAppenderfrom 100 to 1000.Why are the changes needed?
Sometimes (see traces in SPARK-30599) additional info is logged via log4j, and appended to
LogAppender. For example, unusual log entries are:and a test which uses
LogAppendercan fail with the exception:Does this PR introduce any user-facing change?
No
How was this patch tested?
By re-running
"SPARK-23786: warning should be printed if CSV header doesn't conform to schema"in a loop.