Skip to content

Conversation

@iRakson
Copy link
Contributor

@iRakson iRakson commented Dec 27, 2019

What changes were proposed in this pull request?

Documentation added for refresh resources command in spark-sql.

Why are the changes needed?

Previously, only refresh table command was documented.

Does this PR introduce any user-facing change?

Yes. Now users can access documentation for refresh resources command.

How was this patch tested?

Manually.

@iRakson
Copy link
Contributor Author

iRakson commented Dec 27, 2019

@HyukjinKwon
Copy link
Member

ok to test

@SparkQA
Copy link

SparkQA commented Dec 27, 2019

Test build #115856 has finished for PR 27023 at commit a9930a1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.


### Description
`REFRESH` is used to invalidate and refresh all the cached data (and the associated metadata) for
all Dataset, that contains the given data source path. Path matching is by prefix, i.e. "/" would
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dataset, that -> Datasets that


### Examples
{% highlight sql %}
REFRESH /tmp/test.jar;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pardon, I just don't know the semantics well, but how does refreshing a JAR file relate to invalidating data associated with a Dataset?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, we need more concrete examples, e.g. define a table, cache it, then refresh it by path...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iRakson iRakson requested review from maropu and srowen December 30, 2019 13:34
@SparkQA
Copy link

SparkQA commented Dec 30, 2019

Test build #115958 has finished for PR 27023 at commit 13273b4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. I guess there's not much to say here.

@srowen srowen closed this in ce7a49f Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants