[SPARK-30261][SQL] Should not change owner of hive table for some commands like 'alter' operation

[southernriver]

What changes were proposed in this pull request?

For SparkSQL,When we do some alter operations on hive table, the owner of hive table would be changed to someone who invoked the operation, it's unresonable. And in fact, the owner should not changed for the real prodcution environment, otherwise the authority check is out of order.

The problem can be reproduced as described in the below:

1. First I create a table with username='xie' and then desc formatted table ,the owner is 'xiepengjie'

spark-sql> desc formatted bigdata_test.tt1;
col_name data_type comment
c int NULL
# Detailed Table Information
Database bigdata_test
Table tt1
Owner xie
Created Time Wed Sep 11 11:30:49 CST 2019
Last Access Thu Jan 01 08:00:00 CST 1970
Created By Spark 2.2 or prior
Type MANAGED
Provider hive
Table Properties [PART_LIMIT=10000, transient_lastDdlTime=1568172649, LEVEL=1, TTL=60]
Location hdfs://NS1/user/hive_admin/warehouse/bigdata_test.db/tt1
Serde Library org.apache.hadoop.hive.ql.io.orc.OrcSerde
InputFormat org.apache.hadoop.hive.ql.io.orc.OrcInputFormat
OutputFormat org.apache.hadoop.hive.ql.io.orc.OrcOutputFormat
Storage Properties [serialization.format=1]
Partition Provider Catalog
Time taken: 0.371 seconds, Fetched 18 row(s)

2. Then I use another username='johnchen' and execute alter table bigdata_test.tt1 set location 'hdfs://NS1/user/hive_admin/warehouse/bigdata_test.db/tt1', check the owner of hive table is 'johnchen', it's unresonable

spark-sql> desc formatted bigdata_test.tt1;
col_name        data_type       comment
c       int     NULL
 
# Detailed Table Information
Database        bigdata_test
Table   tt1
Owner   johnchen
Created Time    Wed Sep 11 11:30:49 CST 2019
Last Access     Thu Jan 01 08:00:00 CST 1970
Created By      Spark 2.2 or prior
Type    MANAGED
Provider        hive
Table Properties        [transient_lastDdlTime=1568871017, PART_LIMIT=10000, LEVEL=1, TTL=60]
Location        hdfs://NS1/user/hive_admin/warehouse/bigdata_test.db/tt1
Serde Library   org.apache.hadoop.hive.ql.io.orc.OrcSerde
InputFormat     org.apache.hadoop.hive.ql.io.orc.OrcInputFormat
OutputFormat    org.apache.hadoop.hive.ql.io.orc.OrcOutputFormat
Storage Properties      [serialization.format=1]
Partition Provider      Catalog
Time taken: 0.041 seconds, Fetched 18 row(s)

Why are the changes needed?

In fact, the owner should not changed for the real prodcution environment, otherwise the authority check is out of order.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Manual

[AmplabJenkins]

Can one of the admins verify this patch?

[HeartSaVioR]

Thanks for the contribution. @southernriver

1. Could you resolve the conflict?
2. Could we add UT for verifying the patch?

[HeartSaVioR]

cc. @cloud-fan @gatorsmile @dongjoon-hyun

[cloud-fan]

I roughly remember this has been fixed, cc @viirya @yaooqinn

[HeartSaVioR]

Ah you're right. SPARK-29498 (#26160) fixed this and that seems to be the reason of conflict.
@southernriver Could you check SPARK-29498 and close this?

[yaooqinn]

shouldn't be a problem any longer

[southernriver]

Ah you're right. SPARK-29498 (#26160) fixed this and that seems to be the reason of conflict.
@southernriver Could you check SPARK-29498 and close this?

yes,this is the reason, i'll close this ,thank you all!