[SPARK-30235][CORE] Switching off host local disk reading of shuffle blocks in case of useOldFetchProtocol #26869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #115245 has finished for PR 26869 at commit
|
core/src/main/scala/org/apache/spark/storage/BlockManager.scala
Outdated
Show resolved
Hide resolved
Member
|
BTW, @attilapiros . Could you recover the original PR template? |
|
Test build #115357 has finished for PR 26869 at commit
|
vanzin
reviewed
Dec 16, 2019
core/src/main/scala/org/apache/spark/internal/config/package.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/storage/BlockManager.scala
Outdated
Show resolved
Hide resolved
|
Test build #115426 has finished for PR 26869 at commit
|
|
Test build #115434 has finished for PR 26869 at commit
|
Contributor
Author
|
jenkins retest this please |
|
Test build #115450 has finished for PR 26869 at commit
|
Contributor
|
Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When
spark.shuffle.useOldFetchProtocolis enabled then switching off the direct disk reading of host-local shuffle blocks and falling back to remote block fetching (and this way avoiding theGetLocalDirsForExecutorsblock transfer message which is introduced from Spark 3.0.0).Why are the changes needed?
In
[SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same hosta new block transfer message is introduced,GetLocalDirsForExecutors. This new message could be sent to the external shuffle service and as it is not supported by the previous version of external shuffle service it should be avoided whenspark.shuffle.useOldFetchProtocolis true.In the migration guide I changed the exception type as
org.apache.spark.network.shuffle.protocol.BlockTransferMessage.Decoder#fromByteBufferthrows a IllegalArgumentException with the given text and uses the message type which is just a simple number (byte). I have checked and this is true for version 2.4.4 too.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
This specific case (considering one extra boolean to switch off host local disk reading feature) is not tested but existing tests were run.