[SPARK-29152][2.4][CORE] Executor Plugin shutdown when dynamic allocation is enabled #26841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @vanzin |
Contributor
|
ok to test |
|
Test build #115134 has finished for PR 26841 at commit
|
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Dec 11, 2019
dongjoon-hyun
pushed a commit
that referenced
this pull request
Dec 11, 2019
…tion is enabled ### What changes were proposed in this pull request? Added `shutdownHook` for shutdown method of executor plugin. This will ensure that shutdown method will be called always. ### Why are the changes needed? Whenever executors are not going down gracefully, i.e getting killed due to idle time or getting killed forcefully, shutdown method of executors plugin is not getting called. Shutdown method can be used to release any resources that plugin has acquired during its initialisation. So its important to make sure that every time a executor goes down shutdown method of plugin gets called. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Tested Manually Closes #26841 from iRakson/SPARK-29152_2.4. Authored-by: root1 <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Hi, All. I'm testing this PR on Jenkins Maven job because this seems to have a side effect. |
Member
|
I reproduced the same failure by triggerring Maven PR builder on Also, I'm testing the result about reverting this, @iRakson . |
Member
|
In #26900 , I verified that the Maven Jenkins is recovered after reverting this. |
Member
|
@iRakson Could you make a PR once more with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added
shutdownHookfor shutdown method of executor plugin. This will ensure that shutdown method will be called always.Why are the changes needed?
Whenever executors are not going down gracefully, i.e getting killed due to idle time or getting killed forcefully, shutdown method of executors plugin is not getting called. Shutdown method can be used to release any resources that plugin has acquired during its initialisation. So its important to make sure that every time a executor goes down shutdown method of plugin gets called.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Tested Manually