[SPARK-30193]Wrong 2nd argument type. Found: 'org.apache.spark.sql.Column', required: 'scala.collection.Seq<org.apache.spark.sql.Column>' #26825
Conversation
|
Can one of the admins verify this patch? |
…lumn', required: 'scala.collection.Seq<org.apache.spark.sql.Column>'
|
@dongjoon-hyun and @srowen, please review this PR |
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
Can you show how you tested? IIRC, PR builder compiles examples.
|
@HyukjinKwon , you mean local build screenshot you want ? |
I want the commands you ran to verify the compilation failure you faced. |
|
This issue I got to know when I am fixing this problem. |
|
I observed this issue in my IDE when I open this file, not using any command |
|
The build seems already fine. It seems even fine in my IDE. It's likely your env issue. |
|
This changes not required? |
|
Yes, because the build passes fine and it can't reproduce this issue in my IDE. It looks likely the issue in your env. |
|
OK, no problem |
|
There is unused code in java file and exception related warning there in code I will correct the code as per this jira and will raise PR that will be ok? |
|
Will change the jira description also after raising PR? |
|
I would file a separate JIRA. Removing unused codes are minor so I don't think it needs a JIRA. I personally don't like to open a PR only to remove unused codes because it makes backporting harder. |
|
OK fine no problem, thank you 😊 |
|
Hm, yeah I don't see that either. I also don't see how this change could affect the error you cite? it just changes how the same thing is imported. |
|
I also need to see why it's showing for me and my friends also have same issue |
|
But thank you all for giving quick response and guidance. |
|
One question I have, if I found build got failed for any PR and I tried to fixed that build issue and then created jira for that, it's ok? |
|
But at the same time other person raised follow-up PR for that which I don't know, then how you are controlling this thing? |
|
Just for my knowledge I am asking because I tried to resolved unused import issue problem and some other person also raised PR for that |
|
Just file an issue and comment that "I'm working on this". Regarding unused import issue, I've raised a PR two hours earlier than your PR, so in reality you've missed my PR before start to work. Does this explain your concern? |
|
OK got it, I was late, and I missed yours PR |
|
Once again thanks everyone. |
|
First, I'd check whether the Jenkins builds are green. If they are, then it's not a Spark problem, almost surely. You can be a little more conservative about opening PRs and JIRAs there. I'm not sure what you're asking... if someone fixes an issue before you do, is that a problem? no, just happens. It's rare anyway, unless it's an obvious build breakage. If someone proposes a fix for a JIRA you reported? also not necessarily a problem; work together on the best solution. You can say "I'm working on this" sure, but we don't particularly encourage anyone to own the solution. We do need people to collaborate in good faith towards one solution. What JIRA are we talking about? If you're asking about removing unused imports, I wouldn't bother. |
|
@srowen, now everything is clear, I will take care of all this suggestions in future. |
6 participants
What changes were proposed in this pull request?
Wrong 2nd argument type. Found: 'org.apache.spark.sql.Column', required: 'scala.collection.Seq<org.apache.spark.sql.Column>'
Why are the changes needed?
Fixed java file compilation error problem.
Wrong 2nd argument type. Found: 'org.apache.spark.sql.Column', required: 'scala.collection.Seq<org.apache.spark.sql.Column>'
Does this PR introduce any user-facing change?
No
How was this patch tested?
build examples module locally