-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-30159][SQL][FOLLOWUP] Fix lint-java via removing unnecessary imports #26818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you, @HeartSaVioR ! |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. This passed GitHub Action linter.
Merged to master.
|
@HeartSaVioR Thanks for the follow-up |
|
Test build #115044 has finished for PR 26818 at commit
|
|
Thanks all for reviewing and merging! |
|
Thanks for fixing it. Hm, I wonder why there's a diff ... |
#26820 seems to be an answer; we don't fail the build even though there're style guide violations. In script of Github Action, we run |
|
Yes.
|
|
I mean, Jenkins uses I don't believe the linter doesn't fail in PR builder if this isn't a regression - I tested it when I added it. |
What changes were proposed in this pull request?
This patch fixes the Java code style violations in SPARK-30159 (#26788) which are caught by lint-java (Github Action caught it and I can reproduce it locally). Looks like Jenkins build may have different policy on checking Java style check or less accurate.
Why are the changes needed?
Java linter starts complaining.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
lint-java passed locally
This closes #26819