[SPARK-30093][SQL] Improve error message for creating view #26731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @gatorsmile |
Contributor
Author
cloud-fan
reviewed
Dec 3, 2019
| // temporary views are only stored in the session catalog | ||
| throw new AnalysisException(s"Not allowed to create a permanent view $name by " + | ||
| s"referencing a temporary view $ident") | ||
| s"referencing a temporary view $ident (use TEMPORARY keyword)") |
Contributor
There was a problem hiding this comment.
nit: ... referencing a temporary view $ident. Please create a temp view instead by CREATE TEMP VIEW
Contributor
Author
|
Jenkins, test this please. |
Contributor
Author
|
cc @cloud-fan |
Contributor
|
ok to test |
|
Test build #114858 has finished for PR 26731 at commit
|
|
Test build #114865 has finished for PR 26731 at commit
|
Contributor
Author
|
cc @cloud-fan |
Contributor
|
thanks, merging to master! |
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Dec 6, 2019
### What changes were proposed in this pull request? Improved error message while creating views. ### Why are the changes needed? Error message should suggest user to use TEMPORARY keyword while creating permanent view referred by temporary view. apache#26317 (comment) ### Does this PR introduce any user-facing change? No ### How was this patch tested? Updated test case. Closes apache#26731 from amanomer/imp_err_msg. Authored-by: Aman Omer <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improved error message while creating views.
Why are the changes needed?
Error message should suggest user to use TEMPORARY keyword while creating permanent view referred by temporary view.
#26317 (comment)
Does this PR introduce any user-facing change?
No
How was this patch tested?
Updated test case.