[SPARK-28752][BUILD][FOLLOWUP] Fix to install rouge instead of rogue
#26686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
We should also fix the typo that @srowen mentioned: #26521 (comment) |
Member
Author
|
Yes. I'll update this PR~ |
Member
|
The Ruby update may not be necessary. It was after all coming from installing a totally unrelated library. But, still not a bad idea IMHO to update it. |
dongjoon-hyun
changed the title
rougerouge instead of rogue
Member
Author
|
Yes. I updated this PR first for only types. I'm building the docker image to make it sure. |
Member
Author
|
Thank you for swift review and approval, @jiangxb1987 ! |
Member
Author
|
Thank you, @jiangxb1987 and @srowen . |
HyukjinKwon
reviewed
Nov 26, 2019
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
Thanks for fixing this @dongjoon-hyun. LGTM too
Member
Author
|
Thanks, @HyukjinKwon . |
|
Test build #114486 has finished for PR 26686 at commit
|
|
Test build #114484 has finished for PR 26686 at commit
|
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Dec 6, 2019
### What changes were proposed in this pull request? This PR aims to fix a type; `rogue` -> `rouge` . This is a follow-up of apache#26521. ### Why are the changes needed? To support `Python 3`, we upgraded from `pygments` to `rouge`. ### Does this PR introduce any user-facing change? No. (This is for only document generation.) ### How was this patch tested? Manually. ``` $ docker build -t test dev/create-release/spark-rm/ ... 1 gem installed Successfully installed rouge-3.13.0 Parsing documentation for rouge-3.13.0 Installing ri documentation for rouge-3.13.0 Done installing documentation for rouge after 4 seconds 1 gem installed Removing intermediate container 9bd8707d9e84 ---> a18b2f6b0bb9 ... ``` Closes apache#26686 from dongjoon-hyun/SPARK-28752. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix a type;
rogue->rouge.This is a follow-up of #26521.
Why are the changes needed?
To support
Python 3, we upgraded frompygmentstorouge.Does this PR introduce any user-facing change?
No. (This is for only document generation.)
How was this patch tested?
Manually.