[SPARK-30074][SQL] The maxNumPostShufflePartitions config should obey reducePostShufflePartitions enabled #26664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
reviewed
Nov 25, 2019
| buildConf("spark.sql.adaptive.shuffle.targetPostShuffleInputSize") | ||
| .doc("The target post-shuffle input size in bytes of a task.") | ||
| .doc("The target post-shuffle input size in bytes of a task. This configuration only has " + | ||
| s"an effect when '${ADAPTIVE_EXECUTION_ENABLED.key}' is enabled.") |
Contributor
There was a problem hiding this comment.
and also when spark.sql.adaptive.shuffle.reducePostShufflePartitions.enabled is true?
Member
Author
There was a problem hiding this comment.
Thanks, fix the doc of SHUFFLE_MIN_NUM_POSTSHUFFLE_PARTITIONS and SHUFFLE_TARGET_POSTSHUFFLE_INPUT_SIZE.
|
Test build #114407 has finished for PR 26664 at commit
|
|
Test build #114423 has finished for PR 26664 at commit
|
cloud-fan
reviewed
Nov 26, 2019
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Nov 26, 2019
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
Outdated
Show resolved
Hide resolved
xuanyuanking
changed the title
|
Test build #114602 has finished for PR 26664 at commit
|
Member
Author
|
retest this please. |
|
Test build #114617 has finished for PR 26664 at commit
|
Contributor
|
thanks, merging to master! |
Member
Author
|
Thanks! |
manuzhang
reviewed
Dec 2, 2019
| case class EnsureRequirements(conf: SQLConf) extends Rule[SparkPlan] { | ||
| private def defaultNumPreShufflePartitions: Int = | ||
| if (conf.adaptiveExecutionEnabled) { | ||
| if (conf.adaptiveExecutionEnabled && conf.reducePostShufflePartitionsEnabled) { |
Member
There was a problem hiding this comment.
@xuanyuanking is there any UT verifying the number of shuffle partitions dependent on values of these two configurations ?
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Dec 6, 2019
… reducePostShufflePartitions enabled ### What changes were proposed in this pull request? 1. Make maxNumPostShufflePartitions config obey reducePostShfflePartitions config. 2. Update the description for all the SQLConf affected by `spark.sql.adaptive.enabled`. ### Why are the changes needed? Make the relation between these confs clearer. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Existing UT. Closes apache#26664 from xuanyuanking/SPARK-9853-follow. Authored-by: Yuanjian Li <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
spark.sql.adaptive.enabled.Why are the changes needed?
Make the relation between these confs clearer.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UT.