Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Nov 23, 2019

What changes were proposed in this pull request?

This is a follow-up according to @liancheng 's advice.

Why are the changes needed?

Previously, we chose the full version to be carefully. As of today, it seems that Apache Hive 2.3 branch seems to become stable.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the compile combination on GitHub Action.

  1. hadoop-2.7/hive-1.2/JDK8
  2. hadoop-2.7/hive-2.3/JDK8
  3. hadoop-3.2/hive-2.3/JDK8
  4. hadoop-3.2/hive-2.3/JDK11

Also, pass the Jenkins with hadoop-2.7 and hadoop-3.2 for (1) and (4).
(2) and (3) is not ready in Jenkins.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-29981][BUILD][FOLLOWUP] Change hive.version.short [SPARK-29981][BUILD][FOLLOWUP][test-hadoop3.2] Change hive.version.short Nov 23, 2019
@dongjoon-hyun
Copy link
Member Author

Retest this please.

@dongjoon-hyun
Copy link
Member Author

cc @liancheng , @srowen , @wangyum , @HyukjinKwon

@SparkQA
Copy link

SparkQA commented Nov 23, 2019

Test build #114319 has finished for PR 26645 at commit e89d211.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Nov 23, 2019

I'm OK with it pending tests. It's just a move of files, right?

@dongjoon-hyun
Copy link
Member Author

Yes, right, @srowen .

@dongjoon-hyun
Copy link
Member Author

The first run on hadoop-2.7/hive-1.2 is currently running SparkR test.
The second run on hadoop-3.2/hive-2.3 seems to fail due to Objenesis mock flakiness.

sbt.ForkMain$ForkError: org.mockito.exceptions.base.MockitoException: 
ClassCastException occurred while creating the mockito mock :
  class to mock : 'javax.servlet.http.HttpServletRequest', loaded by classloader : 'sun.misc.Launcher$AppClassLoader@490d6c15'
  created class : 'org.mockito.codegen.HttpServletRequest$MockitoMock$1109942067', loaded by classloader : 'net.bytebuddy.dynamic.loading.MultipleParentClassLoader@6e9119e9'
  proxy instance class : 'org.mockito.codegen.HttpServletRequest$MockitoMock$1109942067', loaded by classloader : 'net.bytebuddy.dynamic.loading.MultipleParentClassLoader@6e9119e9'
  instance creation by : ObjenesisInstantiator

@SparkQA
Copy link

SparkQA commented Nov 23, 2019

Test build #114318 has finished for PR 26645 at commit e89d211.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Thank you for review. Merged to master.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-29981][BUILD][FOLLOWUP][test-hadoop3.2] Change hive.version.short [SPARK-29981][BUILD][FOLLOWUP] Change hive.version.short Nov 23, 2019
@dongjoon-hyun dongjoon-hyun deleted the SPARK-RENAME-HIVE-DIRECTORY branch November 23, 2019 22:51
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants