-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-26499][SQL][FOLLOW-UP] Replace update with setByte for ByteType in JdbcUtils.makeGetter
#26532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
|
Test build #113818 has finished for PR 26532 at commit
|
|
retest this please |
|
Test build #113826 has finished for PR 26532 at commit
|
|
The test cases should be fixed as of 65a189c |
|
retest this please |
|
Oh, nice! Thanks for the re-trigger. |
|
Test build #113841 has finished for PR 26532 at commit
|
|
Test build #4935 has finished for PR 26532 at commit
|
|
Merged to master. The change was already in 2.4 from another related commit |
What changes were proposed in this pull request?
This is a follow-up pr to fix the code coming from #23400; it replaces
updatewithsetBytefor ByteType inJdbcUtils.makeGetter.Why are the changes needed?
For better code.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.