Skip to content

Conversation

@maropu
Copy link
Member

@maropu maropu commented Nov 14, 2019

What changes were proposed in this pull request?

This is a follow-up pr to fix the code coming from #23400; it replaces update with setByte for ByteType in JdbcUtils.makeGetter.

Why are the changes needed?

For better code.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@SparkQA
Copy link

SparkQA commented Nov 15, 2019

Test build #113818 has finished for PR 26532 at commit 04c525b.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu
Copy link
Member Author

maropu commented Nov 15, 2019

retest this please

@SparkQA
Copy link

SparkQA commented Nov 15, 2019

Test build #113826 has finished for PR 26532 at commit 04c525b.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

The test cases should be fixed as of 65a189c

@HyukjinKwon
Copy link
Member

retest this please

@maropu
Copy link
Member Author

maropu commented Nov 15, 2019

Oh, nice! Thanks for the re-trigger.

@SparkQA
Copy link

SparkQA commented Nov 15, 2019

Test build #113841 has finished for PR 26532 at commit 04c525b.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 15, 2019

Test build #4935 has finished for PR 26532 at commit 04c525b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen srowen closed this in ee4784b Nov 15, 2019
@srowen
Copy link
Member

srowen commented Nov 15, 2019

Merged to master. The change was already in 2.4 from another related commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants