[WIP][SPARK-29845][SQL]PostgreSQL dialect: cast to decimal #26518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Please remove WIP before requesting reviews? Anyway, can you wait until #26472 merged? That's because that pr is adding a base class for this kind of Pg-specific casts. |
|
Thank you for contribution, @iRakson . As you know, unfortunately, we decided to remove PostgreSQL dialect via SPARK-30125 (#26763). Sorry about that. I'll close this PR, too. |
|
We can still have this feature, but not under pgsql dialect. The ANSI SQL standard also requires us to throw exception when casting invalid strings to numbers. @iRakson can you open new PRs to bring back your cast behaviors changes under the |
|
Yeah Sure. I will. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
cast to decimal behaviour in SparkSQL is made consistent with PostgreSQL when spark.sql.dialect is set to PostgreSQL.
Why are the changes needed?
SparkSQL and PostgreSQL behaviour is very different when casting to decimal.
For e.g:
select cast('abc' to decimal) in SparkSQL gives null.
select cast('abc' to decimal) in PostgreSQL gives "invalid input syntax for type numeric"
Does this PR introduce any user-facing change?
Yes.
How was this patch tested?
Manually tested. Test cases will be added soon