[SPARK-29666][BUILD] Fix the publish release failure under dry-run mode #26329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Oct 30, 2019
Member
There was a problem hiding this comment.
+1, LGTM. Thank you, @jiangxb1987 .
To reviewers, the logic is correct because local installation is okay with Dry Run.
Merged to master/2.4.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Oct 30, 2019
`release-build.sh` fail to publish release under dry run mode with the following error message: ``` /opt/spark-rm/release-build.sh: line 429: pushd: spark-repo-g4MBm/org/apache/spark: No such file or directory ``` We need to at least run the `mvn clean install` command once to create the `$tmp_repo` path, but now those steps are all skipped under dry-run mode. This PR fixes the issue. Tested locally. Closes #26329 from jiangxb1987/dryrun. Authored-by: Xingbo Jiang <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 155a67d) Signed-off-by: Dongjoon Hyun <[email protected]>
Contributor
Author
|
Thanks @dongjoon-hyun ! |
|
Test build #112962 has finished for PR 26329 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
release-build.shfail to publish release under dry run mode with the following error message:We need to at least run the
mvn clean installcommand once to create the$tmp_repopath, but now those steps are all skipped under dry-run mode. This PR fixes the issue.How was this patch tested?
Tested locally.