-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-29453][WEBUI] Improve tooltips information for SQL tab. #26216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@AmplabJenkins ,Thank you , please help me to review my PR. |
|
Thank you for your contribution, @07ARB . I updated the PR title. You can see the available labels here (https://github.com/apache/spark/labels). We need to use use |
|
ok to test |
|
Test build #112489 has finished for PR 26216 at commit
|
|
@dongjoon-hyun Thank you, from next time onward I will remember to use correct labels. |
|
Test build #112490 has finished for PR 26216 at commit
|
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/AllExecutionsPageSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/ToolTips.scala
Outdated
Show resolved
Hide resolved
|
retest this please |
|
ok |
|
@07ARB . I updated the PR description a little. |
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/AllExecutionsPageSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/ToolTips.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/ToolTips.scala
Outdated
Show resolved
Hide resolved
|
@dongjoon-hyun,@shahidki31 Thank you, i will work on given comments and will raise PR again.If any other suggestion please write it. |
|
Test build #112512 has finished for PR 26216 at commit
|
|
Test build #112537 has finished for PR 26216 at commit
|
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/AllExecutionsPageSuite.scala
Outdated
Show resolved
Hide resolved
### What changes were proposed in this pull request?
Adding tooltip to SQL tab for better usability.
https://issues.apache.org/jira/browse/SPARK-29453
### Why are the changes needed?
There are a few common points of confusion in the UI that could be clarified with tooltips. We should add tooltips to explain.
### Does this PR introduce any user-facing change?
yes.
### How was this patch tested?
1) Unit tests (written unit test cases to verify changes).
2) Manual test.
Authored-by: Ankit Raj Boudh <[email protected]>
Remove tab character from file.
modify code as per the review comments.
fixed all the review comments
fixed all the review comments
|
Test build #112553 has finished for PR 26216 at commit
|
|
@dongjoon-hyun,@HeartSaVioR and @shahidki31 please review the latest changes. |
|
Test build #112556 has finished for PR 26216 at commit
|
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
Show resolved
Hide resolved
### What changes were proposed in this pull request?
Adding tooltip to SQL tab for better usability.
https://issues.apache.org/jira/browse/SPARK-29453
### Why are the changes needed?
There are a few common points of confusion in the UI that could be clarified with tooltips. We should add tooltips to explain.
### Does this PR introduce any user-facing change?
yes.
### How was this patch tested?
1) Unit tests (written unit test cases to verify changes).
2) Manual test.
Authored-by: Ankit Raj Boudh <[email protected]>
Remove tab character from file.
modify code as per the review comments.
fixed all the review comments
fixed all the review comments
fixed review comments
…RK-29453 # Conflicts: # sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it hurts, but I don't think this adds much
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
Outdated
Show resolved
Hide resolved
### What changes were proposed in this pull request?
Adding tooltip to SQL tab for better usability.
https://issues.apache.org/jira/browse/SPARK-29453
### Why are the changes needed?
There are a few common points of confusion in the UI that could be clarified with tooltips. We should add tooltips to explain.
### Does this PR introduce any user-facing change?
yes.
### How was this patch tested?
1) Unit tests (written unit test cases to verify changes).
2) Manual test.
Authored-by: Ankit Raj Boudh <[email protected]>
Remove tab character from file.
modify code as per the review comments.
fixed all the review comments
fixed all the review comments
fixed review comments.
…RK-29453 # Conflicts: # sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
|
Test build #112670 has finished for PR 26216 at commit
|
|
Test build #112666 has finished for PR 26216 at commit
|
|
Test build #112668 has finished for PR 26216 at commit
|


What changes were proposed in this pull request?
Adding tooltip to SQL tab for better usability.
Why are the changes needed?
There are a few common points of confusion in the UI that could be clarified with tooltips. We should add tooltips to explain.
Does this PR introduce any user-facing change?
Yes.
How was this patch tested?