Skip to content

Conversation

@07ARB
Copy link
Contributor

@07ARB 07ARB commented Oct 22, 2019

What changes were proposed in this pull request?

Adding tooltip to SQL tab for better usability.

Why are the changes needed?

There are a few common points of confusion in the UI that could be clarified with tooltips. We should add tooltips to explain.

Does this PR introduce any user-facing change?

Yes.

How was this patch tested?

  1. Unit tests (written unit test cases to verify changes).
  2. Manual test.

@07ARB
Copy link
Contributor Author

07ARB commented Oct 22, 2019

Image 2019-10-23 at 1 23 01 AM

@07ARB
Copy link
Contributor Author

07ARB commented Oct 22, 2019

@AmplabJenkins ,Thank you , please help me to review my PR.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-29453][SQL TAB] Improve tooltips information for SQL tab. [SPARK-29453][WEBUI] Improve tooltips information for SQL tab. Oct 22, 2019
@dongjoon-hyun
Copy link
Member

Thank you for your contribution, @07ARB . I updated the PR title. You can see the available labels here (https://github.com/apache/spark/labels). We need to use use WEBUI tag.

@dongjoon-hyun
Copy link
Member

ok to test

@SparkQA
Copy link

SparkQA commented Oct 22, 2019

Test build #112489 has finished for PR 26216 at commit bd6b62f.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@07ARB
Copy link
Contributor Author

07ARB commented Oct 22, 2019

@dongjoon-hyun Thank you, from next time onward I will remember to use correct labels.

@SparkQA
Copy link

SparkQA commented Oct 23, 2019

Test build #112490 has finished for PR 26216 at commit ebef6d6.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shahidki31
Copy link
Contributor

retest this please

@07ARB
Copy link
Contributor Author

07ARB commented Oct 23, 2019

ok

@dongjoon-hyun
Copy link
Member

@07ARB . I updated the PR description a little.

@07ARB
Copy link
Contributor Author

07ARB commented Oct 23, 2019

@dongjoon-hyun,@shahidki31 Thank you, i will work on given comments and will raise PR again.If any other suggestion please write it.

@SparkQA
Copy link

SparkQA commented Oct 23, 2019

Test build #112512 has finished for PR 26216 at commit ebef6d6.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 23, 2019

Test build #112537 has finished for PR 26216 at commit 7123a2f.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

    ### What changes were proposed in this pull request?
    Adding tooltip to SQL tab for better usability.
    https://issues.apache.org/jira/browse/SPARK-29453

    ### Why are the changes needed?
    There are a few common points of confusion in the UI that could be clarified with tooltips. We should add tooltips to explain.

    ### Does this PR introduce any user-facing change?
    yes.

    ### How was this patch tested?
    1) Unit tests (written unit test cases to verify changes).
    2) Manual test.

    Authored-by: Ankit Raj Boudh <[email protected]>

Remove tab character from file.

modify code as per the review comments.

fixed all the review comments

fixed all the review comments
@SparkQA
Copy link

SparkQA commented Oct 23, 2019

Test build #112553 has finished for PR 26216 at commit 811083a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@07ARB
Copy link
Contributor Author

07ARB commented Oct 23, 2019

@dongjoon-hyun,@HeartSaVioR and @shahidki31 please review the latest changes.

@SparkQA
Copy link

SparkQA commented Oct 23, 2019

Test build #112556 has finished for PR 26216 at commit cbcab45.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@07ARB
Copy link
Contributor Author

07ARB commented Oct 24, 2019

screenshot after fixed all the review comments
Screenshot 2019-10-24 at 12 17 44 AM

@07ARB 07ARB requested a review from dongjoon-hyun October 24, 2019 19:59
07ARB added 2 commits October 25, 2019 14:02
    ### What changes were proposed in this pull request?
    Adding tooltip to SQL tab for better usability.
    https://issues.apache.org/jira/browse/SPARK-29453

    ### Why are the changes needed?
    There are a few common points of confusion in the UI that could be clarified with tooltips. We should add tooltips to explain.

    ### Does this PR introduce any user-facing change?
    yes.

    ### How was this patch tested?
    1) Unit tests (written unit test cases to verify changes).
    2) Manual test.

    Authored-by: Ankit Raj Boudh <[email protected]>

Remove tab character from file.

modify code as per the review comments.

fixed all the review comments

fixed all the review comments

fixed review comments
…RK-29453

# Conflicts:
#	sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it hurts, but I don't think this adds much

07ARB added 3 commits October 25, 2019 19:13
    ### What changes were proposed in this pull request?
    Adding tooltip to SQL tab for better usability.
    https://issues.apache.org/jira/browse/SPARK-29453

    ### Why are the changes needed?
    There are a few common points of confusion in the UI that could be clarified with tooltips. We should add tooltips to explain.

    ### Does this PR introduce any user-facing change?
    yes.

    ### How was this patch tested?
    1) Unit tests (written unit test cases to verify changes).
    2) Manual test.

    Authored-by: Ankit Raj Boudh <[email protected]>

Remove tab character from file.

modify code as per the review comments.

fixed all the review comments

fixed all the review comments

fixed review comments.
…RK-29453

# Conflicts:
#	sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
@SparkQA
Copy link

SparkQA commented Oct 25, 2019

Test build #112670 has finished for PR 26216 at commit e958370.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@07ARB 07ARB closed this Oct 25, 2019
@07ARB 07ARB deleted the SPARK-29453 branch October 25, 2019 14:39
@SparkQA
Copy link

SparkQA commented Oct 25, 2019

Test build #112666 has finished for PR 26216 at commit 0eeb5df.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 25, 2019

Test build #112668 has finished for PR 26216 at commit 0d5062f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants