[SQL] Kill dangerous trailing space in query string

[liancheng]

MD5 of query strings in createQueryTest calls are used to generate golden files, leaving trailing spaces there can be really dangerous. Got bitten by this while working on #2616: my "smart" IDE automatically removed a trailing space and makes Jenkins fail.

(Really should add "no trailing space" to our coding style guidelines!)

[SparkQA]

QA tests have started for PR 2619 at commit 034f119.

• This patch merges cleanly.

[SparkQA]

QA tests have finished for PR 2619 at commit 034f119.

• This patch passes unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21133/

[marmbrus]

Good catch! Merged to master.

[nchammas]

(Really should add "no trailing space" to our coding style guidelines!)

FWIW, pep8 is enforcing this rule for us for our Python codebase.

[marmbrus]

+1 @nchammas

I'd be in favor of adding such a check to our scala style checks (though I think it won't fit into the current framework and would have to be done separately). Perhaps suggest this on the dev list?