[SPARK-29108][SQL][TESTS] Port window.sql (Part 2) #26121
Conversation
Signed-off-by: DylanGuedes <[email protected]>
|
add to whitelist |
|
Test build #112097 has finished for PR 26121 at commit
|
|
@DylanGuedes Thanks for the work. |
|
#26107 is merged. Thanks, @gengliangwang . |
|
Retest this please. |
|
Test build #112122 has finished for PR 26121 at commit
|
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
Seems fine. I'm going to merge this in few days.
| -- nth_value(salary, 1) over(order by salary range between 1000 preceding and 1000 following), | ||
| -- salary from empsalary; | ||
|
|
||
| select last(salary) over(order by salary range between 1000 preceding and 1000 following), |
There was a problem hiding this comment.
Nit: It would be better if the SQL keywords are all in UPPERCASE.
There was a problem hiding this comment.
I can make them uppercase, but, are you sure? I think that in PostgreSQL they are not always uppercase, such that the diff will be totally different.
|
I'm going to just merge this. It has been open so long and I am sure it has been exposed to reviewers enough time. |
|
Merged to master. |
5 participants
What changes were proposed in this pull request?
This PR ports window.sql from PostgreSQL regression tests https://github.com/postgres/postgres/blob/REL_12_STABLE/src/test/regress/sql/window.sql from lines 320~562
The expected results can be found in the link: https://github.com/postgres/postgres/blob/REL_12_STABLE/src/test/regress/expected/window.out
How was this patch tested?
Pass the Jenkins.
Why are the changes needed?
To ensure compatibility with PGSQL
Does this PR introduce any user-facing change?
No
How was this patch tested?
Comparison with PgSQL results.