Skip to content

Conversation

@nchammas
Copy link
Contributor

This PR allows SparkQA (i.e. Jenkins) to report in its posts to GitHub what category of test failed, if one can be determined.

The failure categories are:

  • general failure
  • RAT checks failed
  • Scala style checks failed
  • Python style checks failed
  • Build failed
  • Spark unit tests failed
  • PySpark unit tests failed
  • MiMa checks failed

This PR also fixes the diffing logic used to determine if a patch introduces new classes.

@nchammas
Copy link
Contributor Author

I'm gonna post several test commits here to try out the various failure modes and confirm that they are reported correctly.

@nchammas nchammas force-pushed the report-failed-test-category branch from 0f6dcd3 to cc243c9 Compare September 30, 2014 22:41
@SparkQA
Copy link

SparkQA commented Sep 30, 2014

QA tests have started for PR 2606 at commit 935f8c0.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 30, 2014

QA tests have finished for PR 2606 at commit 935f8c0.

  • This patch fails some tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21072/

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21070/

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21080/

@nchammas
Copy link
Contributor Author

nchammas commented Oct 1, 2014

Jenkins failed to checkout the patch.

Jenkins, retest this please.

@nchammas
Copy link
Contributor Author

nchammas commented Oct 1, 2014

Jenkins, retest this please.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21081/

@nchammas
Copy link
Contributor Author

nchammas commented Oct 1, 2014

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Oct 1, 2014

QA tests have started for PR 2606 at commit d5624ac.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 1, 2014

QA tests have finished for PR 2606 at commit d5624ac.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class PStatsParam(AccumulatorParam):

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21083/

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21084/

@nchammas
Copy link
Contributor Author

nchammas commented Oct 1, 2014

Grr, Jenkins flakiness checking out stuff from git...

Oi Jenkins! Retest this please.

@nchammas
Copy link
Contributor Author

nchammas commented Oct 1, 2014

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Oct 1, 2014

QA tests have started for PR 2606 at commit 4f5f338.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 1, 2014

QA tests have finished for PR 2606 at commit 4f5f338.

  • This patch fails RAT tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class PStatsParam(AccumulatorParam):

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21085/

@SparkQA
Copy link

SparkQA commented Oct 1, 2014

QA tests have started for PR 2606 at commit 7289777.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 1, 2014

QA tests have started for PR 2606 at commit 833e064.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 1, 2014

QA tests have finished for PR 2606 at commit 7289777.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21086/

@SparkQA
Copy link

SparkQA commented Oct 1, 2014

QA tests have finished for PR 2606 at commit 833e064.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21087/

@SparkQA
Copy link

SparkQA commented Oct 1, 2014

QA tests have started for PR 2606 at commit 1fea6ce.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 1, 2014

QA tests have finished for PR 2606 at commit 1fea6ce.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • abstract class RDDD[T: ClassTag](

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21116/

@SparkQA
Copy link

SparkQA commented Oct 1, 2014

QA tests have started for PR 2606 at commit 28ffbab.

  • This patch merges cleanly.

@nchammas
Copy link
Contributor Author

nchammas commented Oct 1, 2014

sigh... more checkout troubles.

@nchammas
Copy link
Contributor Author

nchammas commented Oct 1, 2014

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Oct 1, 2014

QA tests have started for PR 2606 at commit f137249.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 1, 2014

QA tests have finished for PR 2606 at commit f137249.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class Dummy()

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21143/

@nchammas
Copy link
Contributor Author

nchammas commented Oct 1, 2014

Hmm, I expected a failure in the PySpark doctests, not here.

@nchammas
Copy link
Contributor Author

nchammas commented Oct 1, 2014

Jenkins, retest this please.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21147/

@nchammas
Copy link
Contributor Author

nchammas commented Oct 1, 2014

Another checkout timeout.

@nchammas
Copy link
Contributor Author

nchammas commented Oct 1, 2014

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Oct 1, 2014

QA tests have started for PR 2606 at commit f137249.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 1, 2014

QA tests have finished for PR 2606 at commit f137249.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class Dummy()

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21152/

@nchammas nchammas force-pushed the report-failed-test-category branch from f137249 to d67df03 Compare October 1, 2014 20:48
@SparkQA
Copy link

SparkQA commented Oct 1, 2014

QA tests have started for PR 2606 at commit d67df03.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 1, 2014

QA tests have finished for PR 2606 at commit d67df03.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21154/

@nchammas
Copy link
Contributor Author

nchammas commented Oct 2, 2014

cc @pwendell This PR is ready for review.

Here are examples of the messages posted when:

@nchammas nchammas changed the title [SPARK-3479] [Build] [WIP] Report failed test category [SPARK-3479] [Build] Report failed test category Oct 2, 2014
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do a valid diff regardless of the merge-ability of the patch, so I moved this out of the if block.

@JoshRosen
Copy link
Contributor

This looks great! Thanks for adding the extra comments to explain the $sha and $ghprbActualCommit variables, since they can be kind of confusing.

@nchammas
Copy link
Contributor Author

nchammas commented Oct 6, 2014

@pwendell @JoshRosen Is this PR ready to be merged in?

@JoshRosen
Copy link
Contributor

Sure, this looks fine to me so I'm going to merge it now. Thanks!

@asfgit asfgit closed this in 69c3f44 Oct 6, 2014
@nchammas nchammas deleted the report-failed-test-category branch October 8, 2014 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants