Skip to content

Conversation

@TomokoKomiyama
Copy link
Contributor

What changes were proposed in this pull request?

Changed 'Phive-thriftserver' to ' -Phive-thriftserver'.

Why are the changes needed?

Typo

Does this PR introduce any user-facing change?

Yes.

How was this patch tested?

Manually tested.

@dongjoon-hyun
Copy link
Member

ok to test

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Sep 26, 2019

Thanks. Looks correct, @TomokoKomiyama . Is this the last typo? Could you try to find more instance on that document?

BTW, @TomokoKomiyama .
I removed [MINOR] from the PR title. [MINOR] is used when we don't have Apache Spark JIRA ID (SPARK-XXX).

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-29256][DOCS][MINOR] Fix typo in building document [SPARK-29256][DOCS] Fix typo in building document Sep 26, 2019
@TomokoKomiyama
Copy link
Contributor Author

@dongjoon-hyun I tried it, but I can't find so far.

Thank you for teaching me about [MINOR].

@SparkQA
Copy link

SparkQA commented Sep 26, 2019

Test build #111406 has finished for PR 25937 at commit b8d8d3d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen srowen closed this in 8beb736 Sep 26, 2019
@srowen
Copy link
Member

srowen commented Sep 26, 2019

Merged to master. You don't need a JIRA for MINOR issues

@dongjoon-hyun
Copy link
Member

Thank you, @TomokoKomiyama and @srowen .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants