-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-29255][SQL][TESTS] Rename package pgSQL to postgreSQL #25936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks ok to me. also cc: @dongjoon-hyun @HyukjinKwon |
|
Test build #111397 has finished for PR 25936 at commit
|
|
retest this please. |
|
@gengliangwang . Could you handle the followings together? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM except only the above minor request (changing the path in sql script comment consistently).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too except @dongjoon-hyun's comments
|
@dongjoon-hyun Thanks for the suggestion. |
|
Test build #111399 has finished for PR 25936 at commit
|
|
Test build #111412 has finished for PR 25936 at commit
|
|
Merged to master. |
|
Thank you all! |
|
Thanks, @gengliangwang ! |
What changes were proposed in this pull request?
Rename the package pgSQL to postgreSQL
Why are the changes needed?
To address the comment in #25697 (comment) . The official full name seems more reasonable.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing unit tests.