[SPARK-29249][SQL] V2 writer: Don't allow tableProperty for existing tables #25931
+1
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cloud-fan, this addresses your comment: #25681 (comment) |
rdblue
changed the title
cloud-fan
approved these changes
Sep 26, 2019
|
Test build #111371 has finished for PR 25931 at commit
|
|
thanks, merging to master! |
|
Thanks for reviewing, @cloud-fan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Don't allow calling append, overwrite, or overwritePartitions after tableProperty is used in DataFrameWriterV2 because table properties are not set as part of operations on existing tables. Only tables that are created or replaced can set table properties.
Why are the changes needed?
The properties are discarded otherwise, so this avoids confusing behavior.
Does this PR introduce any user-facing change?
Yes, but to a new API, DataFrameWriterV2.
How was this patch tested?
Removed test cases that used this method and the append, etc. methods because they no longer compile.