[SPARK-29246][CORE] Remove unnecessary imports in core module
#25927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ExecutorBackendSuite
|
Hi, @sev7e0 . We usually do module-by-module for this kind of task. Could you find more in |
|
Thanks for your comment. I will try to check the rest of |
|
Thank you, @sev7e0 . You can use |
|
Hi, @dongjoon-hyun . I have checked the imports in all the files in |
dongjoon-hyun
changed the title
core module
|
ok to test |
dongjoon-hyun
approved these changes
Sep 26, 2019
There was a problem hiding this comment.
+1, LGTM. (Pending Jenkins).
Thank you so much, @sev7e0 ! Although GitHub Action already verified the compilation, we had better pass the Jenkins testing. I'll merge this after test completion.
maropu
approved these changes
Sep 26, 2019
|
Test build #111455 has finished for PR 25927 at commit
|
|
Ok. Thank you, @dongjoon-hyun and @maropu ！ |
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove unnecessary imports in
coremodule.Why are the changes needed?
Clean code for Apache Spark 3.0.0.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Local test.