Skip to content

Conversation

@wangyum
Copy link
Member

@wangyum wangyum commented Sep 20, 2019

What changes were proposed in this pull request?

This PR use java-version instead of version for GitHub Action. More details:
actions/setup-java@204b974
actions/setup-java@ac25aee

Why are the changes needed?

The version property will not be supported after October 1, 2019.

Does this PR introduce any user-facing change?

No

How was this patch tested?

N/A

@SparkQA
Copy link

SparkQA commented Sep 20, 2019

Test build #111062 has finished for PR 25866 at commit 24859a2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 20, 2019

Test build #111067 has finished for PR 25866 at commit f68c8f2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @wangyum !
Merged to master/2.4.

dongjoon-hyun pushed a commit that referenced this pull request Sep 20, 2019
This PR use `java-version` instead of `version` for GitHub Action. More details:
actions/setup-java@204b974
actions/setup-java@ac25aee

The `version` property will not be supported after October 1, 2019.

No

N/A

Closes #25866 from wangyum/java-version.

Authored-by: Yuming Wang <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 9e234a5)
Signed-off-by: Dongjoon Hyun <[email protected]>
@wangyum wangyum deleted the java-version branch September 21, 2019 03:06
scunniff pushed a commit to scunniff/nomad-spark that referenced this pull request Nov 10, 2020
This PR use `java-version` instead of `version` for GitHub Action. More details:
actions/setup-java@204b974
actions/setup-java@ac25aee

The `version` property will not be supported after October 1, 2019.

No

N/A

Closes apache#25866 from wangyum/java-version.

Authored-by: Yuming Wang <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 9e234a5)
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants