[MINOR][BUILD][2.4] Fix 4 misc build warnings #25857
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses about 15 miscellaneous warnings that appear in the current build. No functional changes, it just slightly reduces the amount of extra warning output. No. Existing tests, run manually. Closes apache#25852 from srowen/BuildWarnings. Authored-by: Sean Owen <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Sep 19, 2019
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you, @srowen . +1, LGTM.
|
Test build #111022 has finished for PR 25857 at commit
|
Member
|
Merged to |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 20, 2019
This addresses 4 miscellaneous warnings that appear in the current build. Back-port of some of #25852 Closes #25857 from srowen/BuildWarnings2.4. Authored-by: Sean Owen <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses 4 miscellaneous warnings that appear in the current build.
Back-port of some of #25852