-
Couldn't load subscription status.
- Fork 28.9k
[SPARK-29053][WEBUI] Sort does not work on some columns #25855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ok to test |
|
Test build #111011 has finished for PR 25855 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but do other pages have a similar problem too? I would not be surprised.
|
No, I haven't found this issue anywhere else. |
|
thanks @srowen |
|
Test build #4879 has finished for PR 25855 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @amanomer . Thank you for your contribution. I'd like to recommend the followings first.
- Please attach your PR's screenshot. The current one is your internal one as you see the Spark version
2.3.2.020x. - While you are here, could you fix the
Execution Timewhich is the very left column to this?Execution Timehas the same issue. If you build your PR branch, you can see that column.- Please see line 74.
After fixing the above two, you need to update the PR title and description and JIRA accordingly, too. Thanks!
|
@dongjoon-hyun thanks for your feedback. |
|
Thanks, @amanomer . I'll review again after you update this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good pending tests.
|
Test build #111079 has finished for PR 25855 at commit
|
|
Merged to master. It didn't pick cleanly into 2.4. If we need it there, open another PR with the back-port. |
|
Thanks @srowen . |
Setting custom sort key for duration and execution time column. Sorting on duration and execution time columns consider time as a string after converting into readable form which is the reason for wrong sort results as mentioned in [SPARK-29053](https://issues.apache.org/jira/browse/SPARK-29053). No Test manually. Screenshots are attached. After patch: **Duration**  **Execution time**  Closes apache#25855 from amanomer/SPARK29053. Authored-by: aman_omer <[email protected]> Signed-off-by: Sean Owen <[email protected]>
What changes were proposed in this pull request?
Setting custom sort key for duration and execution time column.
Why are the changes needed?
Sorting on duration and execution time columns consider time as a string after converting into readable form which is the reason for wrong sort results as mentioned in SPARK-29053.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Test manually. Screenshots are attached.
After patch:


Duration
Execution time