[SPARK-29165][SQL][TEST] Set log level of log generated code as ERROR in case of compile error on generated code in UT #25835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nerated code in UT
HeartSaVioR
changed the title
Member
|
plz file a jira for better traceability? |
maropu
changed the title
Contributor
Author
|
OK I'll file one. Thanks for the guide. |
Member
|
Thanks! |
maropu
reviewed
Sep 19, 2019
| private def logGeneratedCode(code: CodeAndComment): Unit = { | ||
| val maxLines = SQLConf.get.loggingMaxLinesForCodegen | ||
| if (Utils.isTesting) { | ||
| // log as ERROR so that it can be always logged in UT |
Member
There was a problem hiding this comment.
Since its clear what the code is, I personally think we don't need this comment.
Member
|
cc: @cloud-fan @viirya |
HeartSaVioR
changed the title
cloud-fan
approved these changes
Sep 19, 2019
Contributor
|
@dongjoon-hyun do you know how to re-trigger the github checks? One of them fails and it seems flaky. |
viirya
approved these changes
Sep 19, 2019
|
Test build #110940 has finished for PR 25835 at commit
|
|
Test build #110953 has finished for PR 25835 at commit
|
Member
|
@cloud-fan . Yes. I knew it and retriggered before in another PRs, but the current UI seems to have a bug. In general, click the |
dongjoon-hyun
approved these changes
Sep 19, 2019
Member
There was a problem hiding this comment.
+1, LGTM. This is very useful. Merged to master/2.4.
Thank you, @HeartSaVioR , @maropu , @cloud-fan , @viirya .
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 19, 2019
… in case of compile error on generated code in UT ### What changes were proposed in this pull request? This patch proposes to change the log level of logging generated code in case of compile error being occurred in UT. This would help to investigate compilation issue of generated code easier, as currently we got exception message of line number but there's no generated code being logged actually (as in most cases of UT the threshold of log level is at least WARN). ### Why are the changes needed? This would help investigating issue on compilation error for generated code in UT. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? N/A Closes #25835 from HeartSaVioR/MINOR-always-log-generated-code-on-fail-to-compile-in-unit-testing. Authored-by: Jungtaek Lim (HeartSaVioR) <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit eee2e02) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Although this is a kind of improvement, this will reduce our maintenance cost (especially on LTS branch). So, I backported to |
Contributor
Author
|
Thanks all for reviewing and merging! |
HeartSaVioR
deleted the
MINOR-always-log-generated-code-on-fail-to-compile-in-unit-testing
branch
scunniff
pushed a commit
to scunniff/nomad-spark
that referenced
this pull request
Nov 10, 2020
… in case of compile error on generated code in UT ### What changes were proposed in this pull request? This patch proposes to change the log level of logging generated code in case of compile error being occurred in UT. This would help to investigate compilation issue of generated code easier, as currently we got exception message of line number but there's no generated code being logged actually (as in most cases of UT the threshold of log level is at least WARN). ### Why are the changes needed? This would help investigating issue on compilation error for generated code in UT. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? N/A Closes apache#25835 from HeartSaVioR/MINOR-always-log-generated-code-on-fail-to-compile-in-unit-testing. Authored-by: Jungtaek Lim (HeartSaVioR) <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit eee2e02) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch proposes to change the log level of logging generated code in case of compile error being occurred in UT. This would help to investigate compilation issue of generated code easier, as currently we got exception message of line number but there's no generated code being logged actually (as in most cases of UT the threshold of log level is at least WARN).
Why are the changes needed?
This would help investigating issue on compilation error for generated code in UT.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A