[SPARK-29115][SQL][TEST] Add benchmarks for make_date() and make_timestamp() #25813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Sep 17, 2019
|
Test build #110758 has finished for PR 25813 at commit
|
dongjoon-hyun
approved these changes
Sep 17, 2019
There was a problem hiding this comment.
+1, LGTM, too.
Thank you, @MaxGekk and @HyukjinKwon !
Merged to master.
|
Apache JIRA is under maintenance now. I'll update the JIRA later~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added new benchmarks for
make_date()andmake_timestamp()to detect performance issues, and figure out functions speed on foldable arguments.make_date()is benchmarked on fully foldable arguments.make_timestamp()is benchmarked on corner case60.0, foldable time fields and foldable date.Why are the changes needed?
To find out inputs where
make_date()andmake_timestamp()have performance problems. This should be useful in the future optimizations of the functions and users apps.Does this PR introduce any user-facing change?
No
How was this patch tested?
By running the benchmark and manually checking generated dates/timestamps.