Skip to content

Conversation

@turboFei
Copy link
Member

@turboFei turboFei commented Sep 17, 2019

What changes were proposed in this pull request?

In this PR, I fix some annotation errors and remove meaningless annotations in project.

Why are the changes needed?

There are some annotation errors and meaningless annotations in project.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Verified manually.

@turboFei turboFei changed the title [SPARK-29113] Fix some annotation errors in ApplicationCache.scala [SPARK-29113][DOC] Fix some annotation errors in ApplicationCache.scala Sep 17, 2019
@wangyum
Copy link
Member

wangyum commented Sep 17, 2019

ok to test

Copy link
Member

@wangyum wangyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cloud you find more annotation errors?

@turboFei
Copy link
Member Author

I'am reading the code of history server part recently.
And In this PR, I have fix the annotation errors of history server part.
I will try my best to found if there are more annotation errors in whole project.

@HyukjinKwon
Copy link
Member

Yea, let's at least try to find some more instances while we're here. The changes are fine.

@SparkQA
Copy link

SparkQA commented Sep 17, 2019

Test build #110742 has finished for PR 25809 at commit efc08dc.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Sep 17, 2019

Yeah, agree we can fix several more of these. A quick inspection says look at ExplainUtils too.

I'm also in favor of removing empty docs like @param foo with no description or @throws foo with no detail, as they don't actually do anything. But there are a lot of those. So maybe just the one additional class here.

@turboFei turboFei changed the title [SPARK-29113][DOC] Fix some annotation errors in ApplicationCache.scala [WIP][SPARK-29113][DOC] Fix some annotation errors in ApplicationCache.scala Sep 17, 2019
@turboFei turboFei changed the title [WIP][SPARK-29113][DOC] Fix some annotation errors in ApplicationCache.scala [WIP][SPARK-29113][DOC] Fix some annotation errors and remove meaningless annotations in project. Sep 17, 2019
@SparkQA
Copy link

SparkQA commented Sep 17, 2019

Test build #110817 has finished for PR 25809 at commit c73f505.

  • This patch fails build dependency tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 17, 2019

Test build #110813 has finished for PR 25809 at commit 6341184.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@turboFei turboFei changed the title [WIP][SPARK-29113][DOC] Fix some annotation errors and remove meaningless annotations in project. [SPARK-29113][DOC] Fix some annotation errors and remove meaningless annotations in project. Sep 18, 2019
@SparkQA
Copy link

SparkQA commented Sep 18, 2019

Test build #110843 has finished for PR 25809 at commit fbc6417.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants