[SPARK-28932][BUILD][FOLLOWUP] Switch to scala-library compile dependency for JDK11 #25800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…twork-common module for JDK11
|
Verified. After this patch: |
viirya
approved these changes
Sep 16, 2019
|
Thank you again, @viirya ! |
|
This doesn't need to run Jenkins because the new dependency is stronger than the previous one. In addition, this doesn't change dependency manifest and is verified manually me and @viirya . I'll merged this. |
rshkv
pushed a commit
to palantir/spark
that referenced
this pull request
Feb 18, 2021
…ency for JDK11 ### What changes were proposed in this pull request? This is a follow-up of apache#25638 to switch `scala-library` from `test` dependency to `compile` dependency in `network-common` module. ### Why are the changes needed? Previously, we added `scala-library` as a test dependency to resolve the followings, but it was insufficient to resolve. This PR aims to switch it to compile dependency. ``` $ java -version openjdk version "11.0.3" 2019-04-16 OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.3+7) OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.3+7, mixed mode) $ mvn clean install -pl common/network-common -DskipTests ... [INFO] --- scala-maven-plugin:4.2.0:doc-jar (attach-scaladocs) spark-network-common_2.12 --- error: fatal error: object scala in compiler mirror not found. one error found [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE ``` ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Manually, run the following on JDK11. ``` $ mvn clean install -pl common/network-common -DskipTests ``` Closes apache#25800 from dongjoon-hyun/SPARK-28932-2. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
rshkv
pushed a commit
to palantir/spark
that referenced
this pull request
Feb 19, 2021
…ency for JDK11 ### What changes were proposed in this pull request? This is a follow-up of apache#25638 to switch `scala-library` from `test` dependency to `compile` dependency in `network-common` module. ### Why are the changes needed? Previously, we added `scala-library` as a test dependency to resolve the followings, but it was insufficient to resolve. This PR aims to switch it to compile dependency. ``` $ java -version openjdk version "11.0.3" 2019-04-16 OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.3+7) OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.3+7, mixed mode) $ mvn clean install -pl common/network-common -DskipTests ... [INFO] --- scala-maven-plugin:4.2.0:doc-jar (attach-scaladocs) spark-network-common_2.12 --- error: fatal error: object scala in compiler mirror not found. one error found [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE ``` ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Manually, run the following on JDK11. ``` $ mvn clean install -pl common/network-common -DskipTests ``` Closes apache#25800 from dongjoon-hyun/SPARK-28932-2. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 25, 2023
…K 11 workaround ### What changes were proposed in this pull request? This PR removes the legacy workaround for JDK 11 added at SPARK-28932 ### Why are the changes needed? To remove legacy workaround. With JDK 17, now it seems working. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? As described in #25800 ```bash ./build/mvn clean install -pl common/network-common -DskipTests ``` ``` ... [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 48.139 s [INFO] Finished at: 2023-09-25T12:27:43+09:00 [INFO] ------------------------------------------------------------------------ ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #43086 from HyukjinKwon/SPARK-45301. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of #25638 to switch
scala-libraryfromtestdependency tocompiledependency innetwork-commonmodule.Why are the changes needed?
Previously, we added
scala-libraryas a test dependency to resolve the followings, but it was insufficient to resolve. This PR aims to switch it to compile dependency.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually, run the following on JDK11.