-
Couldn't load subscription status.
- Fork 28.9k
[SPARK-28483][FOLLOW-UP] Fix flaky test in BarrierTaskContextSuite #25799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Jenkins, retest this please. |
core/src/test/scala/org/apache/spark/scheduler/BarrierTaskContextSuite.scala
Outdated
Show resolved
Hide resolved
|
Test build #110634 has finished for PR 25799 at commit
|
|
Test build #4869 has finished for PR 25799 at commit
|
|
retest this please |
|
Test build #110703 has finished for PR 25799 at commit
|
|
Test build #110732 has finished for PR 25799 at commit
|
|
retest this please |
|
Test build #110739 has finished for PR 25799 at commit
|
|
Retest this please. |
|
Test build #110750 has finished for PR 25799 at commit
|
|
@WeichenXu123, while this PR seems fine, please make sure you have a sign-off or an approval from another committer, which is a standard approach. At least, you can wait for some positive comments. Or, please clarify the reason why you're merging it without any sign-off from other people. In this way, you can a) avoid unexpected mistakes, and b) have another person who can take over your change, say, if you happen to leave this project; otherwise, no one can take over if most of changes are just merged without peer-review. Although it is legitimate to merge as a committer as far as I know, we should better stick to this practice. Avoid to set a bad example. |
|
Also, please clarify which branch you merged (e.g., "Merged to master") to avoid the overhead for people to check commit history to see which branch it was merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me.
Yeah I'd say it's a judgment call, if it's a minor change and you feel sure about it and nobody has weighed in for a day or two, it's not unreasonable to proceed. If in doubt I'd try pinging someone for a second look.
|
For the record looks like this was merged to master |
What changes were proposed in this pull request?
I fix the test "barrier task killed" which is flaky:
Why are the changes needed?
Make test robust.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A