[SPARK-29079][INFRA] Enable GitHub Action on PR #25786
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Member
|
LGTM. Merged into master. |
Member
Author
|
Thank you for review and merging, @dbtsai ! |
|
Test build #110573 has finished for PR 25786 at commit
|
PavithraRamachandran
pushed a commit
to PavithraRamachandran/spark
that referenced
this pull request
Sep 15, 2019
### What changes were proposed in this pull request? This PR enables GitHub Action on PRs. ### Why are the changes needed? So far, we detect JDK11 compilation error after merging. This PR aims to prevent JDK11 compilation error at PR stage. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Manual. See the GitHub Action on this PR. Closes apache#25786 from dongjoon-hyun/SPARK-29079. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: DB Tsai <[email protected]>
Member
Author
|
It seems working correctly on |
dongjoon-hyun
added a commit
that referenced
this pull request
Sep 15, 2019
This PR enables GitHub Action on PRs. So far, we detect JDK11 compilation error after merging. This PR aims to prevent JDK11 compilation error at PR stage. No. Manual. See the GitHub Action on this PR. Closes #25786 from dongjoon-hyun/SPARK-29079. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: DB Tsai <[email protected]>
scunniff
pushed a commit
to scunniff/nomad-spark
that referenced
this pull request
Nov 10, 2020
This PR enables GitHub Action on PRs. So far, we detect JDK11 compilation error after merging. This PR aims to prevent JDK11 compilation error at PR stage. No. Manual. See the GitHub Action on this PR. Closes apache#25786 from dongjoon-hyun/SPARK-29079. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: DB Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR enables GitHub Action on PRs.
Why are the changes needed?
So far, we detect JDK11 compilation error after merging.
This PR aims to prevent JDK11 compilation error at PR stage.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual. See the GitHub Action on this PR.