[SPARK-29069][SQL] ResolveInsertInto should not do table lookup #25774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
commented
Sep 12, 2019
| } | ||
| v2TableOpt.map(DataSourceV2Relation.create).getOrElse(u) | ||
|
|
||
| case i @ InsertIntoStatement(u: UnresolvedRelation, _, _, _, _) if i.query.resolved => |
There was a problem hiding this comment.
simpler to ResolveRelations, ResolveTables should handle both UnresolvedRelation and InsertIntoStatement(UnresolvedRelation, ...).
cloud-fan
commented
Sep 12, 2019
| case _ => | ||
| i | ||
| case i @ InsertIntoStatement(r: DataSourceV2Relation, _, _, _, _) if i.query.resolved => | ||
| // ifPartitionNotExists is append with validation, but validation is not supported |
There was a problem hiding this comment.
just indentation changes.
|
Test build #110518 has finished for PR 25774 at commit
|
|
retest this please |
|
Test build #110547 has finished for PR 25774 at commit
|
|
Merged to master. |
|
Late +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It's more clear to only do table lookup in
ResolveTablesrule (for v2 tables) andResolveRelationsrule (for v1 tables).ResolveInsertIntoshould only resolve theInsertIntoStatementwith resolved relations.Why are the changes needed?
to make the code simpler
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests