[SPARK-28856][FOLLOW-UP][SQL][TEST] Add the namespaces keyword to TableIdentifierParserSuite
#25758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ableIdentifierParserSuite
wangyum
changed the title
namespaces keyword to T…namespaces keyword to TableIdentifierParserSuite
|
ok to test |
|
Test build #110477 has finished for PR 25758 at commit
|
|
retest this please |
|
Test build #110497 has finished for PR 25758 at commit
|
|
cc @maropu |
|
Thanks for your help, @highmoutain. This is only one missing entry there? |
|
hi @maropu , I think this is the only one missing. |
maropu
approved these changes
Sep 12, 2019
dongjoon-hyun
approved these changes
Sep 15, 2019
There was a problem hiding this comment.
Welcome to the Apache Spark community and thank you for your first contribution, @highmoutain .
+1, LGTM. Merged to master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR add the
namespaceskeyword toTableIdentifierParserSuite.Why are the changes needed?
Improve the test.
Does this PR introduce any user-facing change?
No
How was this patch tested?
N/A