[SPARK-28340][CORE] Noisy exceptions when tasks are killed: "DiskBloc… #25674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
requested changes
Sep 4, 2019
Member
There was a problem hiding this comment.
Is this second part meaningful? Maybe just ClosedByInterruptException while reverting partial writes to file" + file (i.e. keep the file name)
Member
There was a problem hiding this comment.
Remove the interpolation. Should you name the exception here for clarity? In both cases you could log the exception message in the string here instead, to preserve some detail.
It'd be nice to avoid repeating the results.put(...) ; is this worth it?
case e: Exception =>
e match {
case ce: CloseByInterruptException => logError(...)
case ex: Exception => logError(...)
}
results.put(...)
return
…kObjectWriter: Uncaught exception while reverting partial writes to file: java.nio.channels.ClosedByInterruptException"
colinmjj
force-pushed
the
spark-28340
branch
from
d4a14c6 to
6dac661
Compare
Author
|
@srowen thanks for your comments, the pr is updated. |
Author
|
@jerryshao do you have any comment? |
Contributor
|
ok to test. |
|
Test build #110234 has finished for PR 25674 at commit
|
srowen
approved these changes
Sep 6, 2019
Member
|
Merged to master |
1 similar comment
Member
|
Merged to master |
PavithraRamachandran
pushed a commit
to PavithraRamachandran/spark
that referenced
this pull request
Sep 15, 2019
### What changes were proposed in this pull request? If a Spark task is killed due to intentional job kills, automated killing of redundant speculative tasks, etc, ClosedByInterruptException occurs if task has unfinished I/O operation with AbstractInterruptibleChannel. A single cancelled task can result in hundreds of stack trace of ClosedByInterruptException being logged. In this PR, stack trace of ClosedByInterruptException won't be logged like Executor.run do for InterruptedException. ### Why are the changes needed? Large numbers of spurious exceptions is confusing to users when they are inspecting Spark logs to diagnose other issues. ### Does this PR introduce any user-facing change? No ### How was this patch tested? N/A Closes apache#25674 from colinmjj/spark-28340. Authored-by: colinma <[email protected]> Signed-off-by: Sean Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If a Spark task is killed due to intentional job kills, automated killing of redundant speculative tasks, etc, ClosedByInterruptException occurs if task has unfinished I/O operation with AbstractInterruptibleChannel. A single cancelled task can result in hundreds of stack trace of ClosedByInterruptException being logged.
In this PR, stack trace of ClosedByInterruptException won't be logged like Executor.run do for InterruptedException.
Why are the changes needed?
Large numbers of spurious exceptions is confusing to users when they are inspecting Spark logs to diagnose other issues.
Does this PR introduce any user-facing change?
No
How was this patch tested?
N/A