[SPARK-3715][Docs]minor typo #2567
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA tests have started for PR 2567 at commit
|
Contributor
|
Thanks! I've merged this to master. |
guavuslabs-builder
pushed a commit
to ThalesGroup/spark
that referenced
this pull request
Sep 29, 2014
https://issues.apache.org/jira/browse/SPARK-3715 Author: WangTaoTheTonic <[email protected]> Closes apache#2567 from WangTaoTheTonic/minortypo and squashes the following commits: 9cc3f7a [WangTaoTheTonic] minor typo (cherry picked from commit 1f13a40) Signed-off-by: Michael Armbrust <[email protected]>
|
QA tests have finished for PR 2567 at commit
|
|
Test PASSed. |
tdas
added a commit
to tdas/spark
that referenced
this pull request
Jun 4, 2018
…batch **This PR is not for merging, only for looking at the change. Consider only the changes to the file MicroBatchExecution.scala.** The error occurs when we are recovering from a failure in a no-data batch (say X) that has been planned (i.e. written to offset log) but not executed (i.e. not written to commit log). Upon recovery the following sequence of events happen. 1. `MicroBatchExecution.populateStartOffsets` sets `currentBatchId` to X. Since there was no data in the batch, the `availableOffsets` is same as `committedOffsets`, so `isNewDataAvailable` is `false`. 2. When `MicroBatchExecution.constructNextBatch` is called, ideally it should immediately return true because the next batch has already been constructed. However, the check of whether the batch has been constructed was `if (isNewDataAvailable) return true`. Since the planned batch is a no-data batch, it escaped this check and proceeded to plan the same batch X *once again*. The correct solution is to check the offset log whether the currentBatchId is the latest or not. This is the fix below. TODO Author: Tathagata Das <[email protected]> Closes apache#2567 from tdas/SC-11085.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SPARK-3715