[SPARK-28963][BUILD] Fall back to archive.apache.org in build/mvn for older releases #25667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #110053 has finished for PR 25667 at commit
|
|
Test build #110054 has finished for PR 25667 at commit
|
cloud-fan
approved these changes
Sep 4, 2019
Member
|
Merged to master. |
HyukjinKwon
approved these changes
Sep 4, 2019
Member
|
Hi, All. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Oct 21, 2019
… older releases
### What changes were proposed in this pull request?
Fall back to archive.apache.org in `build/mvn` to download Maven, in case the ASF mirrors no longer have an older release.
### Why are the changes needed?
If an older release's specified Maven doesn't exist in the mirrors, {{build/mvn}} will fail.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
Manually tested different paths and failures by commenting in/out parts of the script and modifying it directly.
Closes #25667 from srowen/SPARK-28963.
Authored-by: Sean Owen <[email protected]>
Signed-off-by: HyukjinKwon <[email protected]>
(cherry picked from commit df39855)
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fall back to archive.apache.org in
build/mvnto download Maven, in case the ASF mirrors no longer have an older release.Why are the changes needed?
If an older release's specified Maven doesn't exist in the mirrors, {{build/mvn}} will fail.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually tested different paths and failures by commenting in/out parts of the script and modifying it directly.