- 
                Notifications
    
You must be signed in to change notification settings  - Fork 28.9k
 
[SPARK-28950][SQL] Refine the code of DELETE #25652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           Test build #110018 has finished for PR 25652 at commit  
  | 
    
| 
           retest this please  | 
    
| 
           Test build #110100 has finished for PR 25652 at commit  
  | 
    
| 
           retest this please  | 
    
| 
           Test build #110107 has finished for PR 25652 at commit  
  | 
    
| 
           Updated the code to sync the modification for both DELETE and UPDATE. And once #25626 gets in, will rebase it against the latest code.  | 
    
| 
           Test build #110133 has finished for PR 25652 at commit  
  | 
    
        
          
                sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
              
                Outdated
          
            Show resolved
            Hide resolved
        
      | 
           looks good, @xianyinxin can you rebase?  | 
    
| 
           Rebased the code against latest master.  | 
    
| 
           Test build #110777 has finished for PR 25652 at commit  
  | 
    
| 
           thanks, merging to master!  | 
    
| 
           Thanks @cloud-fan for reviewing!  | 
    
What changes were proposed in this pull request?
This pr refines the code of DELETE, including, 1, make
whereClauseto be optional, in which case DELETE will delete all of the data of a table; 2, add more test cases; 3, some other refines.This is a following-up of SPARK-28351.
Why are the changes needed?
An optional where clause in DELETE respects the SQL standard.
Does this PR introduce any user-facing change?
Yes. But since this is a non-released feature, this change does not have any end-user affects.
How was this patch tested?
New case is added.