Skip to content

Conversation

@xy-xin
Copy link

@xy-xin xy-xin commented Sep 2, 2019

What changes were proposed in this pull request?

This pr refines the code of DELETE, including, 1, make whereClause to be optional, in which case DELETE will delete all of the data of a table; 2, add more test cases; 3, some other refines.
This is a following-up of SPARK-28351.

Why are the changes needed?

An optional where clause in DELETE respects the SQL standard.

Does this PR introduce any user-facing change?

Yes. But since this is a non-released feature, this change does not have any end-user affects.

How was this patch tested?

New case is added.

@SparkQA
Copy link

SparkQA commented Sep 2, 2019

Test build #110018 has finished for PR 25652 at commit c0c9383.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu
Copy link
Member

maropu commented Sep 4, 2019

retest this please

@maropu maropu changed the title [SPARK-28950] FollowingUp of SPARK-28351: Change whereClause to be optional in DELETE [SPARK-28950][SQL] Change whereClause to be optional in DELETE Sep 4, 2019
@SparkQA
Copy link

SparkQA commented Sep 4, 2019

Test build #110100 has finished for PR 25652 at commit c0c9383.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu
Copy link
Member

maropu commented Sep 4, 2019

retest this please

@SparkQA
Copy link

SparkQA commented Sep 4, 2019

Test build #110107 has finished for PR 25652 at commit c0c9383.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@xy-xin xy-xin changed the title [SPARK-28950][SQL] Change whereClause to be optional in DELETE [SPARK-28950][SQL] Refine the code of DELETE Sep 4, 2019
@xy-xin
Copy link
Author

xy-xin commented Sep 4, 2019

Updated the code to sync the modification for both DELETE and UPDATE. And once #25626 gets in, will rebase it against the latest code.

@SparkQA
Copy link

SparkQA commented Sep 4, 2019

Test build #110133 has finished for PR 25652 at commit 3080d82.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

looks good, @xianyinxin can you rebase?

@xy-xin
Copy link
Author

xy-xin commented Sep 17, 2019

Rebased the code against latest master.
BTW, 1, the keywords description for 'DELETE' 'FROM' is already in sql-keywords.md; 2, document for DELETE need to be add in another pr.

@SparkQA
Copy link

SparkQA commented Sep 17, 2019

Test build #110777 has finished for PR 25652 at commit 65250f3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@cloud-fan cloud-fan closed this in 3fc52b5 Sep 17, 2019
@xy-xin
Copy link
Author

xy-xin commented Sep 18, 2019

Thanks @cloud-fan for reviewing!

@xy-xin xy-xin deleted the SPARK-28950 branch September 18, 2019 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants