Skip to content

[SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API #25634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API #25634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/src/main/scala/org/apache/spark/executor/Executor.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,20 +139,20 @@ private[spark] class Executor(
private val executorPlugins: Seq[ExecutorPlugin] = {
val pluginNames = conf.get(EXECUTOR_PLUGINS)
if (pluginNames.nonEmpty) {
logDebug(s"Initializing the following plugins: ${pluginNames.mkString(", ")}")
logInfo(s"Initializing the following plugins: ${pluginNames.mkString(", ")}")
Copy link
Member

@dongjoon-hyun dongjoon-hyun Aug 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @iRakson . At the PR description, could you describe your reason why this should be INFO?

Copy link
Member

@gatorsmile gatorsmile Aug 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds reasonable to use logInfo for this message. The message is only shown once for each executor. Debug level might be too low here.


// Plugins need to load using a class loader that includes the executor's user classpath
val pluginList: Seq[ExecutorPlugin] =
Utils.withContextClassLoader(replClassLoader) {
val plugins = Utils.loadExtensions(classOf[ExecutorPlugin], pluginNames, conf)
plugins.foreach { plugin =>
plugin.init()
logDebug(s"Successfully loaded plugin " + plugin.getClass().getCanonicalName())
logInfo(s"Successfully loaded plugin " + plugin.getClass().getCanonicalName())
}
plugins
}

logDebug("Finished initializing plugins")
logInfo("Finished initializing plugins")
pluginList
} else {
Nil
Expand Down