Skip to content

Conversation

@shivusondur
Copy link
Contributor

@shivusondur shivusondur commented Aug 24, 2019

What changes were proposed in this pull request?

Added document reference for USE databse sql command

Why are the changes needed?

For USE database command usage

Does this PR introduce any user-facing change?

It is adding the USE database sql command refernce information in the doc

How was this patch tested?

Attached the test snap
image

Copy link
Contributor

@amanomer amanomer Aug 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add related statements like ALTER DATABASE, CREATE DATABASE, DROP DATABASE and SHOW DATABASE.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use backtick( ` ) instead of single quote( ' ).

@shivusondur
Copy link
Contributor Author

@dilipbiswal @gatorsmile
Updated the PR according to #25525 and #25523 PR's.
Updated the ScreenShot after creating the document from Jekyll build

Please review and kindly check for merging.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivusondur Shouldn't { FROM | IN } be in the main syntax diagram if its mentioned as a parameter here ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handled

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivusondur How about

`USE` statement is used to set a current database. After a current database is set, the unqualified database artifacts such as tables, functions  and views that are referenced by SQLs are resolved from the current database. 

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handled

@shivusondur
Copy link
Contributor Author

@dilipbiswal
Thanks for your time for review
I have handled all your comments and updated the screen shot.
please check

@dilipbiswal
Copy link
Contributor

LGTM
cc @gatorsmile

@gatorsmile
Copy link
Member

ok to test

@SparkQA
Copy link

SparkQA commented Sep 19, 2019

Test build #111013 has finished for PR 25572 at commit e370b13.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 19, 2019

Test build #111014 has finished for PR 25572 at commit e370b13.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member

Thanks! Merged to master.

@dilipbiswal
Copy link
Contributor

@gatorsmile Thank you very much for fixing and merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants