[SPARK-28857][INFRA] Clean up the comments of PR template during merging #25564
Conversation
|
Could you review this PR, @gatorsmile , @cloud-fan , @HyukjinKwon ? |
| title = pr["title"] | ||
|
|
||
| body = pr["body"] | ||
| modified_body = re.sub(re.compile(r'<!--[^>]*-->\n?', re.DOTALL), '', pr["body"]).lstrip() |
There was a problem hiding this comment.
lstrip() is used to remove the first PR template comments and new lines. strip() has false positive because it will modify all PR description (which doesn't have comments).
|
thanks for fixing it! LGTM |
|
Thank you for review and approval, @cloud-fan ! |
|
Test build #109616 has finished for PR 25564 at commit
|
|
retest this please |
|
Merged to master given that it's tested. PR builders won't do anything with this script except linter .. :-).. |
|
Test build #109627 has finished for PR 25564 at commit
|
|
Thank you, @cloud-fan , @srowen , @HyukjinKwon ! |
|
I'll cherry-pick this to |
### What changes were proposed in this pull request? This PR aims to clean up the commit logs by removing the comments of our PR template. ### Why are the changes needed? Apache Spark PR template has comments. Sometime we forget to clean up them because GitHub hides them nicely. It would be great if we clean up this. Otherwise, this makes the commit logs too verbose. (There are a few commits already.) ### Does this PR introduce any user-facing change? No. (only for committers) ### How was this patch tested? Manually with Python2/Python3. Closes #25564 from dongjoon-hyun/SPARK-28857. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit 1fd7f29) Signed-off-by: Dongjoon Hyun <[email protected]>
|
cc @viirya |
|
@dongjoon-hyun Yeah, sounds good. Thanks! |
6 participants
What changes were proposed in this pull request?
This PR aims to clean up the commit logs by removing the comments of our PR template.
Why are the changes needed?
Apache Spark PR template has comments. Sometime we forget to clean up them because GitHub hides them nicely. It would be great if we clean up this. Otherwise, this makes the commit logs too verbose. (There are a few commits already.)
Does this PR introduce any user-facing change?
No. (only for committers)
How was this patch tested?
Manually with Python2/Python3.