Skip to content

Conversation

@dilipbiswal
Copy link
Contributor

@dilipbiswal dilipbiswal commented Aug 21, 2019

What changes were proposed in this pull request?

Document DESCRIBE FUNCTION statement in SQL Reference Guide.

Why are the changes needed?

Currently Spark lacks documentation on the supported SQL constructs causing
confusion among users who sometimes have to look at the code to understand the
usage. This is aimed at addressing this issue.

Does this PR introduce any user-facing change?

Yes.

Before:
There was no documentation for this.

After.
Screen Shot 2019-09-02 at 11 14 09 PM
Screen Shot 2019-09-02 at 11 14 29 PM
Screen Shot 2019-09-02 at 11 14 42 PM

How was this patch tested?

Tested using jykyll build --serve

@SparkQA
Copy link

SparkQA commented Aug 21, 2019

Test build #109474 has finished for PR 25530 at commit 6984101.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dilipbiswal
Copy link
Contributor Author

cc @gatorsmile

**This page is under construction**
Return the metadata such as qualified function name, implementing class and usage of an existing function.
Input parameter function name may be optionally qualified. If the function is not qualified then the function is
resolved from the current database. If EXTENDED option is specified then additionally extended usage information
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back-tick EXTENDED, and add "the" before.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srowen Changed. Sean, i also backticked the function_name. Is that ok ?

@SparkQA
Copy link

SparkQA commented Aug 21, 2019

Test build #109513 has finished for PR 25530 at commit 964aa71.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dilipbiswal dilipbiswal changed the title [SPARK-28805][DOC] Document DESCRIBE FUNCTION in SQL Reference [SPARK-28805][DOCS][SQL] Document DESCRIBE FUNCTION in SQL Reference Aug 24, 2019
@dilipbiswal dilipbiswal force-pushed the ref-doc-desc-function branch from 964aa71 to 9a4db23 Compare September 3, 2019 06:13
@SparkQA
Copy link

SparkQA commented Sep 3, 2019

Test build #110030 has finished for PR 25530 at commit 9a4db23.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member

LGTM

Thanks! Merged to master.

@gatorsmile gatorsmile closed this in 94e6674 Sep 3, 2019
@dilipbiswal
Copy link
Contributor Author

@gatorsmile Thank you very much for fixing the mistakes and merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants