Skip to content

[SPARK-28644][SQL] Port HIVE-10646: ColumnValue does not handle NULL_TYPE #25378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-28644][SQL] Port HIVE-10646: ColumnValue does not handle NULL_TYPE #25378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...scala/org/apache/spark/sql/hive/thriftserver/SparkThriftServerProtocolVersionsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,7 @@ class SparkThriftServerProtocolVersionsSuite extends HiveThriftJdbcTest {
}
}

// TODO: enable this test case after port HIVE-10646
ignore(s"$version get void") {
test(s"$version get void") {
testExecuteStatementWithProtocolVersion(version, "SELECT null") { rs =>
assert(rs.next())
assert(rs.getString(1) === null)
Expand Down
2 changes: 2 additions & 0 deletions sql/hive-thriftserver/v1.2.1/src/main/java/org/apache/hive/service/cli/ColumnValue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,8 @@ public static TColumnValue toTColumnValue(Type type, Object value) {
case UNION_TYPE:
case USER_DEFINED_TYPE:
return stringValue((String)value);
case NULL_TYPE:
return stringValue((String)value);
Copy link
Member Author

@wangyum wangyum Aug 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hive 2.3 has fixed this issue:

spark/sql/hive-thriftserver/v2.3.5/src/main/java/org/apache/hive/service/cli/ColumnValue.java

Lines 209 to 210 in 3f102a8

case NULL_TYPE:
return stringValue((String)value);

default:
return null;
}
Expand Down