Skip to content

SPARK-3638 | Forced a compatible version of http client in kinesis-asl profile #2535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

SPARK-3638 | Forced a compatible version of http client in kinesis-asl profile #2535

wants to merge 6 commits into from

Conversation

@aniketbhatnagar
Copy link
Contributor

@aniketbhatnagar aniketbhatnagar commented Sep 25, 2014

This patch forces use of commons http client 4.2 in Kinesis-asl profile so that the AWS SDK does not run into dependency conflicts

@aniketbhatnagar
SPARK-3638 | Forced a compatible version of http client in kinesis-as…
9cd6103 
…l profile

This patch forces commons httpclient 4.2 dependency over an older
httpclient dependency in kinesis-asl-profile so the AWS SDK works
@aniketbhatnagar aniketbhatnagar mentioned this pull request Sep 25, 2014
Closed
@AmplabJenkins
Copy link

AmplabJenkins commented Sep 25, 2014

Can one of the admins verify this patch?

@JoshRosen
Copy link
Contributor

JoshRosen commented Sep 26, 2014

Jenkins, this is ok to test.

@SparkQA
Copy link

SparkQA commented Sep 26, 2014

QA tests have started for PR 2535 at commit 9cd6103.

  • This patch merges cleanly.

JoshRosen
JoshRosen reviewed Sep 26, 2014
View reviewed changes
pom.xml Outdated
Copy link
Contributor

@JoshRosen JoshRosen Sep 26, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind using version 4.2.6 instead of 4.2? According to http://ispras.linuxbase.org/index.php/Java_API_Compliance_Checker, there are no binary incompatibilities between 4.2 and 4.2.6, so we should prefer to use the newer version.

@SparkQA
Copy link

SparkQA commented Sep 26, 2014

QA tests have finished for PR 2535 at commit 9cd6103.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Sep 26, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20884/

@aniketbhatnagar
SPARK-3638 | Forced a compatible version of http client in kinesis-as…
4ed61d8 
…l profile

This patch forces commons httpclient 4.2 dependency over an older
httpclient dependency in kinesis-asl-profile so the AWS SDK works
@aniketbhatnagar
Merge remote-tracking branch 'origin/Kinesis-HttpClient-Dep-Fix' into…
725dbc9 
… Kinesis-HttpClient-Dep-Fix

Conflicts:
	pom.xml
@aniketbhatnagar
deleted merge files
70cc75b
@SparkQA
Copy link

SparkQA commented Sep 27, 2014

QA tests have started for PR 2535 at commit 70cc75b.

  • This patch merges cleanly.

@aniketbhatnagar
SPARK-3638 | Forced a compatible version of http client in kinesis-as…
73f55f6 
…l profile

This patch forces commons httpclient 4.2 dependency over an older
httpclient dependency in kinesis-asl-profile so the AWS SDK works
@aniketbhatnagar
Merge branch 'Kinesis-HttpClient-Dep-Fix' of https://github.com/anike…
aa2079f 
…tbhatnagar/spark into Kinesis-HttpClient-Dep-Fix

Conflicts:
	pom.xml
@aniketbhatnagar
Copy link
Contributor Author

aniketbhatnagar commented Sep 27, 2014

Thanks @JoshRosen, I have bumped up the version to 4.2.6.

@SparkQA
Copy link

SparkQA commented Sep 27, 2014

QA tests have started for PR 2535 at commit aa2079f.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 27, 2014

QA tests have finished for PR 2535 at commit 70cc75b.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Sep 27, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20892/

@SparkQA
Copy link

SparkQA commented Sep 27, 2014

QA tests have finished for PR 2535 at commit aa2079f.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Sep 27, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20893/

@JoshRosen
Copy link
Contributor

JoshRosen commented Oct 2, 2014

This looks good to me. Thanks!

asfgit pushed a commit that referenced this pull request Oct 2, 2014
@aniketbhatnagar @JoshRosen
SPARK-3638 | Forced a compatible version of http client in kinesis-as…
c52c231 
…l profile

This patch forces use of commons http client 4.2 in Kinesis-asl profile so that the AWS SDK does not run into dependency conflicts

Author: aniketbhatnagar <[email protected]>

Closes #2535 from aniketbhatnagar/Kinesis-HttpClient-Dep-Fix and squashes the following commits:

aa2079f [aniketbhatnagar] Merge branch 'Kinesis-HttpClient-Dep-Fix' of https://github.com/aniketbhatnagar/spark into Kinesis-HttpClient-Dep-Fix
73f55f6 [aniketbhatnagar] SPARK-3638 | Forced a compatible version of http client in kinesis-asl profile
70cc75b [aniketbhatnagar] deleted merge files
725dbc9 [aniketbhatnagar] Merge remote-tracking branch 'origin/Kinesis-HttpClient-Dep-Fix' into Kinesis-HttpClient-Dep-Fix
4ed61d8 [aniketbhatnagar] SPARK-3638 | Forced a compatible version of http client in kinesis-asl profile
9cd6103 [aniketbhatnagar] SPARK-3638 | Forced a compatible version of http client in kinesis-asl profile

(cherry picked from commit 93861a5)
Signed-off-by: Josh Rosen <[email protected]>
@asfgit asfgit closed this in 93861a5 Oct 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aniketbhatnagar @AmplabJenkins @JoshRosen @SparkQA