Skip to content

[SPARK-28465][K8s] Fix integration tests which fail due to missing ceph-nano image #25222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-28465][K8s] Fix integration tests which fail due to missing ceph-nano image #25222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ion-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/DepsTestsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ private[spark] trait DepsTestsSuite { k8sSuite: KubernetesSuite =>

private def getCephContainer(): Container = {
val envVars = Map ( "NETWORK_AUTO_DETECT" -> "4",
"RGW_CIVETWEB_PORT" -> "8000",
"RGW_FRONTEND_PORT" -> "8000",
"SREE_PORT" -> "5001",
"CEPH_DEMO_UID" -> "nano",
"CEPH_DAEMON" -> "demo",
Expand All @@ -63,7 +63,7 @@ private[spark] trait DepsTestsSuite { k8sSuite: KubernetesSuite =>
).asJava

new ContainerBuilder()
.withImage("ceph/daemon:v4.0.0-stable-4.0-master-centos-7-x86_64")
.withImage("ceph/daemon:latest")
Copy link
Member

@felixcheung felixcheung Jul 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might break in a future (or future major) version of ceph/daemon? we are sure this will be always compatible?

Copy link
Contributor Author

@skonto skonto Jul 22, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixcheung Nope but if it does I can ping the guys on ceph-nano to help. The safest way to do this (like the way I tried but they deleted the image), is to push an image somewhere and use that. Is there a dockerhub repo which we can use?

Copy link
Contributor

@vanzin vanzin Jul 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless Shane sets up a docker registry that we can use for the integration tests, I guess this is the best we can do for now. I'll merge this to get tests going, we can look at alternatives separately.

.withImagePullPolicy("Always")
.withName(cName)
.withPorts(new ContainerPortBuilder()
Expand Down